Fix #3546: Splitter error with only 1 panel #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
added
the
Core Team
melloware
changed the title
|
Sorry, I did not know children could be non array. But I also wonder if specifying a size for a single panel makes sense, in which case this fix will not apply the size and instead use 100% |
|
Sure I was not expecting someone to use 1 panel. You want to test and submit another PR? |
|
I do not know yet. I will try to check if it makes sense to have one panel width first. |
|
Unfortunately, this fix undid what was fixed by #3535 |
|
I think the next fix should also include a snapshot test, so future errors can be limited. |
|
I have snapshot tests in place now |
|
Yes, but the snapshots contained incorrect values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #3546: Splitter error with only 1 panel