Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginator: v4 page buttons still have PrimeVue classes in unstyled mode #6064

Closed
daniel-hitchins opened this issue Jul 15, 2024 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@daniel-hitchins
Copy link

daniel-hitchins commented Jul 15, 2024

Describe the bug

In unstyled mode, the paginator's page buttons still retain PrimeVue-specific classes. This results in default styles being applied, which conflicts with custom styles added through pass-through props. Unstyled mode is expected to remove all PrimeVue classes to allow for full custom styling.

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-exftqs?file=src%2Fmain.js

PrimeVue version

4.0.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Add the Paginator component to your template with the unstyled prop:

<template>
  <Paginator
    :rows="10"
    :totalRecords="120"
    :rowsPerPageOptions="[10, 20, 30]"
    unstyled
  ></Paginator>
</template>
<script setup></script>

Expected behavior

In unstyled mode, the paginator's page buttons should have all PrimeVue-specific classes removed. This ensures that no default styles are applied, allowing for full custom styling through external CSS or pass-through props.

@daniel-hitchins daniel-hitchins added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 15, 2024
@daniel-hitchins daniel-hitchins changed the title Component Name: Issue Title Paginator: v4 page buttons still have PrimeVue classes in unstyled mode Jul 15, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 22, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.1 milestone Jul 22, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants