Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-disabled state #1014

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Add aria-disabled state #1014

merged 2 commits into from
Jan 23, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jan 3, 2020

This is an alternative to #983 and in the same spirit as #1006.

But instead of replacing the .disabled class, it only adds [aria-disabled=true]. Making it easier to introduce without the need to refactor dotcom's many places where currently the .disabled class and disabled attribute is being used.

  • Add [aria-disabled=true]
  • Update docs

Note: The disabled attribute and .disabled class can still be used for styling, it's just not encouraged and therefore not documented.


Ref. #791
Superseeds and closes #983

@vercel
Copy link

vercel bot commented Jan 3, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/b9ppdi12g
✅ Preview: https://primer-css-git-aria-disabled.primer.now.sh

@vercel vercel bot temporarily deployed to Preview January 3, 2020 12:28 Inactive
@simurai simurai marked this pull request as ready for review January 3, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants