Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosening the primer/primitives dependency to any minor.patch version #1594

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

jonrohan
Copy link
Member

I had tightened this dependency back up recently but we lost the ability to update primitives in dotcom and skip the update here. So I'm bringing back the ^ which will use any ^ version greater than what's in package.json as long as it's not a major release.

/cc @primer/css-reviewers

@jonrohan jonrohan requested a review from a team as a code owner September 15, 2021 22:50
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2021

🦋 Changeset detected

Latest commit: d0432d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we have to be more careful what is considered major and minor/patch on primer/primitives? Having the ^ in the VS Code theme caused that red color bug: primer/github-vscode-theme#210.

@jonrohan
Copy link
Member Author

Does that mean we have to be more careful what is considered major and minor/patch on primer/primitives? Having the ^ in the VS Code theme caused that red color bug: primer/github-vscode-theme#210.

that is true, but we do have the advantage of dotcom not being auto updated like the vscode theme.

@jonrohan jonrohan enabled auto-merge (squash) September 16, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants