Added light & dark colorblind themes #1596
Conversation
🦋 Changeset detectedLatest commit: 3ba0c50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -3,9 +3,12 @@ | |||
| @import "../support/mixins/color-modes.scss"; | |||
|
|
|||
| @import "@primer/primitives/dist/scss/colors/_light.scss"; | |||
| @import "@primer/primitives/dist/scss/colors/_light_protanopia.scss"; | |||
There was a problem hiding this comment.
It seems this file is not available. @jonrohan Shouldn't @primer/primitives@4.8.0 get picked up automatically after changing to the ^ in #1594?
There was a problem hiding this comment.
The change still only uses the one specified in package.json, but it looses the restriction of a codebase that requires both primer/css and primer/primitives.
Basically telling npm, I use 4.7.1, but if someone is using me and needs 4.8.0 then I can use that also.
I've pushed a commit to update to 4.8.0 in this pr to fix the problem.
Just adding the new colorblind themes to
src/base/modes.scssRelated to
/cc @primer/css-reviewers