Release 9.6.0

[broccolini]

closes #361

TODO

• bring stylelint module into monorepo Import stylelint config and rules #365
• move typography into correct module
• publish static site for storybook (off gh-pages)
• Update the changelog
• npm run bump

[shawnbot]

Okay, so I had a lot of trouble getting this to build, and I added some scripts to help us figure out what's going on if we run into this kind of stuff in the future:

1. script/check-imports does a brute-force comparison of each CSS module's dependencies and the imports in its index.scss to ensure that all direct imports are declared as direct dependencies. For example, you can simulate a "bad" import like this:

   $ echo '@import "primer-css/index.scss";' >> modules/primer-utilities/index.scss
   $ ./script/check-imports
   primer-marketing-support: no dependencies
   primer-support: no dependencies
   ⏱  checking 27 modules...
   📦  primer-alerts:              1 dependencies, 1 import(s)
   📦  primer-base:                1 dependencies, 1 import(s)
   📦  primer-avatars:             1 dependencies, 1 import(s)
   📦  primer-blankslate:          1 dependencies, 1 import(s)
   📦  primer-buttons:             1 dependencies, 1 import(s)
   📦  primer-cards:               2 dependencies, 2 import(s)
   📦  primer-breadcrumb:          2 dependencies, 1 import(s)
   📦  primer-box:                 1 dependencies, 1 import(s)
   📦  primer-dropdown:            1 dependencies, 1 import(s)
   📦  primer-forms:               1 dependencies, 1 import(s)
   📦  primer-core:                12 dependencies, 12 import(s)
   📦  primer-css:                 28 dependencies, 3 import(s)
   📦  primer-markdown:            1 dependencies, 1 import(s)
   📦  primer-layout:              1 dependencies, 1 import(s)
   📦  primer-marketing:           9 dependencies, 8 import(s)
   📦  primer-labels:              1 dependencies, 1 import(s)
   📦  primer-marketing-type:      2 dependencies, 2 import(s)
   📦  primer-navigation:          1 dependencies, 1 import(s)
   📦  primer-marketing-utilities: 2 dependencies, 1 import(s)
   📦  primer-page-headers:        2 dependencies, 2 import(s)
   📦  primer-page-sections:       2 dependencies, 2 import(s)
   📦  primer-tables:              2 dependencies, 2 import(s)
   📦  primer-table-object:        1 dependencies, 0 import(s)
   📦  primer-product:             7 dependencies, 7 import(s)
   📦  primer-utilities:           1 dependencies, 2 import(s)
   Error: ❌  primer-utilities imports primer-css, but is missing a dependency

2. script/check-versions ensures that every inter-dependency in our monorepo declares the correct, exact version. This was an issue in the case of primer-dropdown, which depended on an outdated version of primer-support, which messed up the whole hoisting situation.

   # good:
   $ ./script/check-versions
   ⏱   checking 32 packages...
   ✅   checked 88 matching version dependencies
   
   # edit modules/primer-css/package.json and set
   # dependencies.primer-utilities from "4.4.0" to "4.3.0" ... bad:
   $ ./script/check-versions
   ⏱   checking 32 packages...
   primer-css.dependencies has bad version for primer-support: 4.4.0 != 4.3.0

Both scripts will bail (and exit(1)) on the first error.

These two checks should eventually become part of our CI process (we could eve run check-versions after release-candidate to make sure that we've updated all of the right packages), but for now they'll do as manual checks.

[broccolini]

Okay, checked out the built storybook, there's two more to-do's I think before this is ready to ship:

• octicons just has a "test" story in it. Either let's move it or add the rest of the octicon stories back
• can we get the left nav items to be in alphabetical order? it's not immediately obvious to me how to do that but haven't spent long looking into it.

[jonrohan]

publish static site for storybook (off gh-pages)

Ok, I've setup 38ec0af storybook publishing to https://github.com/primer/storybook as a gh-pages site, which will result at the url http://primercss.io/storybook/ right now it's just the text 404 because it's using master as the pages branch. when 9.6 ships we can flip it to use the gh-pages branch

[jonrohan]

Here's my output from npm run bump. There's a lot of modules patched because of year updates 🙊 oops, we'll probably need to write some tests to make sure our licenses have the correct year.

Changes:
 - primer-alerts: 1.5.0 => 1.5.1
 - primer-avatars: 1.4.0 => 1.4.1
 - primer-base: 1.5.0 => 1.5.1
 - primer-blankslate: 1.4.0 => 1.4.1
 - primer-box: 2.5.0 => 2.5.1
 - primer-breadcrumb: 1.4.0 => 1.4.1
 - primer-buttons: 2.4.0 => 2.4.1
 - primer-cards: 0.5.0 => 0.5.1
 - primer-core: 6.4.0 => 6.4.1
 - primer-css: 9.5.0 => 9.6.0
 - primer-forms: 1.4.0 => 1.4.1
 - primer-labels: 1.5.0 => 1.5.1
 - primer-layout: 1.4.0 => 1.4.1
 - primer-markdown: 3.7.0 => 3.7.1
 - primer-marketing-support: 1.3.0 => 1.3.1
 - primer-marketing-type: 1.4.0 => 1.4.1
 - primer-marketing-utilities: 1.4.0 => 1.4.1
 - primer-marketing: 5.4.0 => 5.4.1
 - primer-navigation: 1.4.0 => 1.4.1
 - primer-page-headers: 1.4.0 => 1.4.1
 - primer-page-sections: 1.4.0 => 1.4.1
 - primer-product: 5.4.0 => 5.4.1
 - primer-support: 4.4.0 => 4.4.1
 - primer-table-object: 1.4.0 => 1.4.1
 - primer-tables: 1.4.0 => 1.4.1
 - primer-tooltips: 1.4.0 => 1.4.1
 - primer-truncate: 1.4.0 => 1.4.1
 - primer-utilities: 4.8.0 => 4.8.1
 - generator-primer-module: 0.1.0 => 1.0.0
 - stylelint-config-primer: 2.1.0 => 2.2.0
 - stylelint-selector-no-utility: 1.7.0 => 1.8.0

[broccolini]

@jonrohan your changes LGTM 👍

[jonrohan]

We are good to go 🥗