Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .user-select-none utility class #549

Merged
merged 3 commits into from
Jul 27, 2018
Merged

add .user-select-none utility class #549

merged 3 commits into from
Jul 27, 2018

Conversation

pqt
Copy link
Contributor

@pqt pqt commented Jul 25, 2018

This adds a utility class for .user-select-none

Fixes #546

A very close second for the class name was .no-user-select based on the file contents, however I feel like this was ultimately the better option purely for explicit declaration.

/cc @primer/ds-core

Copy link

@CaptGH CaptGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@shawnbot
Copy link
Contributor

@austinpaquette thanks for this. Could you add a usage example to the docs, please? 🙇

@pqt
Copy link
Contributor Author

pqt commented Jul 26, 2018

All done.

@emplums emplums self-requested a review July 27, 2018 02:27
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Austin!

@emplums emplums changed the base branch from master to release-10.8.0 July 27, 2018 02:27
@emplums emplums merged commit 20ec689 into primer:release-10.8.0 Jul 27, 2018
@emplums emplums mentioned this pull request Jul 27, 2018
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants