Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update releasing docs #608

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Update releasing docs #608

merged 3 commits into from
Nov 20, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Nov 20, 2018 •
edited
Loading

This makes some much-needed updates to our release docs, per a walkthrough with @emilybrick:

  • add all the change category headings to the release PR template
  • remove task to update primer.github.io, as this is just redirects to primer.style now
  • link to the new release page from the checklist
  • provide better guidance on copying the CHANGELOG text from Travis build output

👀 Rendered

🏠 Internal

  • Improve release documentation

/cc @primer/ds-core

@shawnbot
update releasing docs
89f253f 
- remove link to primer.github.io (this is a redirect now)
- link to new release view
- prompt to merge the PR before doing 
- provide better guidance on copying the changelog text from Travis logs
- add all the change category headings to the release PR template
emplums
emplums approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of comments

RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Show resolved Hide resolved
@shawnbot shawnbot mentioned this pull request Nov 20, 2018
Merged
8 tasks
@shawnbot
Copy link
Contributor Author

FYI, the Travis push builds are failing because the release-doc-updates branch matches the release* pattern that we filter branches on to test for package.json version mismatches. I'm going to merge this anyway.

@shawnbot shawnbot merged commit ad31d82 into release-10.10.1 Nov 20, 2018
@shawnbot shawnbot deleted the release-doc-updates branch November 20, 2018 23:05
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 20, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
Tag: Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @emplums