Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 12.0.1 #683

Merged
merged 15 commits into from
Feb 21, 2019
Merged

Release 12.0.1 #683

merged 15 commits into from
Feb 21, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Feb 20, 2019

Primer Patch Release

Version: 📦 12.0.1
Approximate release date: 📆 Feb 20, 2019

🐛 Bug Fix

💅 Polish

🏠 Internal

  • Add postversion npm script that commits package.json and package-lock.json with consistent commit messages (chore: v<version>).

Ship checklist

/cc @primer/ds-core

@shawnbot shawnbot marked this pull request as ready for review February 20, 2019 23:43
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one question!

"lint-js": "eslint lib docs",
"now-build": "next build",
"now-start": "next start",
"postlint": "npm run lint-js",
"postversion": "git commit -m \"chore: v$npm_package_version\" package*.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of doing this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little over-engineered to me. I think most contributors know how to manually change the version, and I think it makes the PR instructions actually more confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained in Slack, but for posterity:

This makes it possible for npm version 12.0.1 or npm version patch to do everything necessary, which matches up with what we instruct people to do (npm version) in the release PR template.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it's not totally necessary tbh. Most people already know how to upgrade a version manually and I'd rather stick to simple processes across all of our repos that are consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! I'll remove it in the next release.

@shawnbot shawnbot merged commit 05b66d8 into master Feb 21, 2019
@shawnbot shawnbot deleted the release-12.0.1 branch February 21, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants