Release 12.0.1 #683
Release 12.0.1 #683
Conversation
Add missing h000-mktg
| "lint-js": "eslint lib docs", | ||
| "now-build": "next build", | ||
| "now-start": "next start", | ||
| "postlint": "npm run lint-js", | ||
| "postversion": "git commit -m \"chore: v$npm_package_version\" package*.json", |
There was a problem hiding this comment.
What's the benefit of doing this?
There was a problem hiding this comment.
This seems a little over-engineered to me. I think most contributors know how to manually change the version, and I think it makes the PR instructions actually more confusing
There was a problem hiding this comment.
I explained in Slack, but for posterity:
This makes it possible for npm version 12.0.1 or npm version patch to do everything necessary, which matches up with what we instruct people to do (npm version) in the release PR template.
There was a problem hiding this comment.
I still think it's not totally necessary tbh. Most people already know how to upgrade a version manually and I'd rather stick to simple processes across all of our repos that are consistent.
There was a problem hiding this comment.
Fair enough! I'll remove it in the next release.
Primer Patch Release
Version: 📦 12.0.1
Approximate release date: 📆 Feb 20, 2019
🐛 Bug Fix
h000-mktgclass Add missing h000-mktg #667💅 Polish
New README image from @ashygee Add Primer CSS Readme Image #644(next time!)🏠 Internal
postversionnpm script that commitspackage.jsonandpackage-lock.jsonwith consistent commit messages (chore: v<version>).Ship checklist
CHANGELOG.mdpackage.jsonwithnpm version <version>/cc @primer/ds-core