Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnderlineNav border #733

Merged
merged 2 commits into from Mar 18, 2019
Merged

Fix UnderlineNav border #733

merged 2 commits into from Mar 18, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Mar 18, 2019 •
edited

This removes the margin-bottom: -1px rule from .UnderlineNav, fixing #732.

While I was in there, I replaced some static values with $border and $border-style variables. Here it is on the branch deployment:

image

@shawnbot shawnbot mentioned this pull request Mar 18, 2019
Merged
10 tasks
ampinsk
ampinsk approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@ampinsk ampinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for grabbing this! Looks good to me 😎

@shawnbot shawnbot merged commit 63bc167 into release-12.2.1 Mar 18, 2019
@shawnbot shawnbot deleted the fix-underlinenav-border branch March 18, 2019 18:52
@gtsiolis gtsiolis mentioned this pull request Apr 18, 2019
Closed
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 17, 2022
Open
Open
This was referenced Dec 25, 2022
Open
Open
This was referenced Jan 4, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ampinsk ampinsk ampinsk approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick

Assignees
No one assigned
Labels
Tag: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawnbot @ampinsk