Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 12.2.1 #730

Merged
merged 24 commits into from Mar 22, 2019
Merged

Release 12.2.1 #730

merged 24 commits into from Mar 22, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Mar 14, 2019 •
edited by simurai

Primer Patch Release

Version: 馃摝 12.2.1
Approximate release date: 馃搯 03/15/2019

馃悰 Bug Fix

馃摑 Documentation

Ship checklist

/cc @primer/ds-core

shawnbot and others added 22 commits February 27, 2019 17:56
@shawnbot
chore: fix changelog committers
4b39bdd
@simurai
Fix popovers from being cut off
cd67010
@simurai
Merge branch 'master' into fix-cut-off-examples
9efb7ee
@simurai
Fix cut off tooltips
30217cf
@simurai
Fix borders of outline labels
3ae46dc 
They have minus margin that makes the border getting cut off.
@simurai
Fix forms from being cut off
5dbf4a6
@simurai
Center negative offset example
a51922f
@simurai
Show position-fixed example
ce47e81
@simurai
Add dot infront of class names
9d2bf3e 
Seems to be a convention in other examples.
@simurai
Change source order of border colors
25077c6 
This allows changing colors on directional borders. E.g. `border-bottom border-green`
@shawnbot
chore: v12.2.1
8adc04a
@shawnbot
Merge pull request #727 from primer/colored-directional-borders
f3622f1 
Allow changing color on directional borders
@shawnbot
Merge pull request #729 from primer/fix-changelog
cc303af 
Fix changelog committers
@simurai
Use display block for iframe
55e9291 
This removes the gap at the bottom
@simurai
Move default padding inside iframe
4a399ac 
This allows things like the focus ring to not get cut off.
@simurai
Move 鈥est inside the Frame
051ef7f
@simurai
Fix linter
45d8a3f
@simurai
Adjust examples
57b97ba 
After moving the default padding inside the iframe
@simurai
Revert "Move 鈥est inside the Frame"
645a61d 
This reverts commit 051ef7f.
@shawnbot
fix(UnderlineNav): remove margin-bottom: -1px for #732
636d4bf
@shawnbot
chore(UnderlineNav): use border variables
a8980c9
@shawnbot
Merge pull request #733 from primer/fix-underlinenav-border
63bc167 
Fix UnderlineNav border
@shawnbot shawnbot marked this pull request as ready for review March 18, 2019 18:52
@shawnbot
Copy link
Contributor Author

@simurai would you mind wrapping this up when you're back online? I didn't list #725 yet or update the changelog, and I can't approve my own PR. If you're feeling confident, feel free to approve once those things are done! 馃檱

@shawnbot shawnbot mentioned this pull request Mar 19, 2019
Merged
simurai
simurai approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殺 馃憤

@simurai
Copy link
Contributor

simurai commented Mar 22, 2019

I tested 12.2.1-rc.1672642 on review-lab and everything seems fine. Let's 馃殺 it.

@simurai simurai merged commit 09674e3 into master Mar 22, 2019
馃摝 Primer CSS release tracking automation moved this from v12.2.1 to 馃挏 Done Mar 22, 2019
@simurai simurai deleted the release-12.2.1 branch March 22, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
馃摝 Primer CSS release tracking
馃挏 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawnbot @simurai