Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Blueprints #764

Merged
merged 12 commits into from
Apr 30, 2019
Merged

Update Blueprints #764

merged 12 commits into from
Apr 30, 2019

Conversation

emplums
Copy link
Contributor

@emplums emplums commented Apr 23, 2019 •
edited
Loading

This PR upgrades Primer CSS to use the 4.0.0 version of primer/blueprints

@emplums emplums changed the title [WIP] Update Blueprints Update Blueprints Apr 25, 2019
@emplums emplums requested a review from shawnbot April 25, 2019 18:22
This was referenced Apr 25, 2019
Merged
Merged
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
docs/markdown.js Outdated Show resolved Hide resolved
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
pages/_app.js Outdated Show resolved Hide resolved
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
pages/_error.js Outdated Show resolved Hide resolved
shawnbot
shawnbot reviewed Apr 26, 2019
View reviewed changes
pages/index.js Outdated Show resolved Hide resolved
shawnbot
shawnbot approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I'd really like to eliminate those direct imports of dist/next-components-index.umd.js if possible. That path gives me the heeby-jeebies.

@shawnbot shawnbot mentioned this pull request Apr 29, 2019
Merged
13 tasks
@shawnbot shawnbot added this to Ready to release in 📦 Primer CSS release tracking Apr 29, 2019
shawnbot and others added 6 commits April 30, 2019 11:05
@shawnbot
Update docs/markdown.js
e5bbf73 
Co-Authored-By: emplums <emplums@github.com>
@shawnbot
Update pages/_app.js
9c7119a 
Co-Authored-By: emplums <emplums@github.com>
@shawnbot
Update pages/index.js
9dca6cc 
Co-Authored-By: emplums <emplums@github.com>
@shawnbot
Update pages/_error.js
d00d2c3 
Co-Authored-By: emplums <emplums@github.com>
update blueprints version
861c9fd
Merge branch 'update-blueprints' of github.com:primer/css into update…
5941b76 
…-blueprints
@emplums emplums merged commit 9ed1375 into master Apr 30, 2019
📦 Primer CSS release tracking automation moved this from Ready to release to 💜 Done Apr 30, 2019
@emplums emplums deleted the update-blueprints branch April 30, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
📦 Primer CSS release tracking
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emplums @shawnbot