Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edit on GitHub links to docs #770

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Add Edit on GitHub links to docs #770

merged 5 commits into from
Apr 30, 2019

Conversation

emplums
Copy link
Contributor

@emplums emplums commented Apr 25, 2019

This PR add the Edit on GitHub links to every page in the docs :)

Branched off of #764, revelant changes are in _app.js
/cc @primer/ds-core

@emplums emplums requested a review from shawnbot April 25, 2019 20:21
docs/markdown.js Outdated Show resolved Hide resolved
pages/_app.js Outdated Show resolved Hide resolved
pages/_error.js Outdated Show resolved Hide resolved
pages/index.js Outdated Show resolved Hide resolved
@shawnbot shawnbot mentioned this pull request Apr 29, 2019
13 tasks
@shawnbot shawnbot changed the base branch from master to release-12.3.0 April 30, 2019 18:37
pages/_app.js Outdated Show resolved Hide resolved
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, but otherwise LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants