Fix .border-dashed
#824
Merged
Fix .border-dashed
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
Update Documentation
This is not needed anymore since it gets added with the responsive mixin
Below responsive variants
|
This pull request is automatically deployed with Now. |
simurai
commented
Jun 17, 2019
| @@ -2,9 +2,6 @@ | |||
| // stylelint-disable primer/selector-no-utility | |||
| // stylelint-disable block-opening-brace-space-before, comment-empty-line-before | |||
|
|
|||
| /* Add a gray border on all edges */ | |||
| .border { border: $border !important; } | |||
There was a problem hiding this comment.
This can be removed since it already gets added part of the responsive variants below.
simurai
moved this from Release backlog
to Ready to release
in 📦 Primer CSS release tracking
|
Follow up - looks to be related: https://github.com/github/github/issues/117836 ? |
This was referenced Dec 14, 2022
This was referenced Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
.border-dashedutility.Problem
It seems that
.border-dashedgets overridden by the responsive variant.Fix
Moving
.border-dashedbelow the responsive variants fixes the issue.Fixes #822