Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 12.4.1 #810

Merged
merged 34 commits into from
Jun 20, 2019
Merged

Release 12.4.1 #810

merged 34 commits into from
Jun 20, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented May 22, 2019 •
edited

Primer CSS Patch Release

Version: 📦 12.4.1
Approximate release date: 📆 June 3, 2019

🐛 Bug fixes

📝 Documentation

🏠 Internal

Ship checklist

  • Update CHANGELOG.md
  • Update the version field in package.json
  • Test the release candidate version with github/github
  • Merge this PR and create a new release
  • Update github/github

For more details, see RELEASING.md.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented May 22, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot temporarily deployed to staging May 22, 2019 23:13 Inactive
@shawnbot
Merge pull request #762 from primer/fix-toc
53b7aa0 
Fix table of contents instances
@shawnbot shawnbot added this to Work in Progress in 📦 Primer CSS release tracking Jun 3, 2019
@shawnbot shawnbot marked this pull request as ready for review June 20, 2019 18:45
@shawnbot shawnbot requested a review from jonrohan June 20, 2019 18:45
jonrohan
jonrohan approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I'm cool with punting on the color docs. And nice we don't have to maintain primer/deploy anymore

@shawnbot shawnbot merged commit e4f69db into master Jun 20, 2019
📦 Primer CSS release tracking automation moved this from Work in Progress to 💜 Done Jun 20, 2019
@shawnbot shawnbot deleted the release-12.4.1 branch July 17, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
📦 Primer CSS release tracking
💜 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

border-dashed Doesn't Work
4 participants
@shawnbot @jonrohan @The-Compiler @simurai