-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RelativeTime #299
RelativeTime #299
Conversation
This is great! I'm wondering if we could make it even better by adding a table with all the formats and examples.
|
Hey, in the figma file (I am assuming you meant to link to <RelativeTime micro={{narrow: true}} datetime={Date} /> Why do you have to set the |
Co-authored-by: Lukas Oppermann <lukasoppermann@github.com>
Co-authored-by: Lukas Oppermann <lukasoppermann@github.com>
Co-authored-by: Lukas Oppermann <lukasoppermann@github.com>
Right! I changed the link 👍 . Following the same approach as the <RelativeTime micro={{narrow: true, regular: false, wide: false}} datetime={new Date("2022-12-26")}> |
Good idea 👍 I'll add it as part of the content section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two suggestions, otherwise I think this is ✨
Co-authored-by: simurai <simurai@github.com>
Co-authored-by: simurai <simurai@github.com>
Tracking issue: https://github.com/github/primer/issues/1252
Figma: https://www.figma.com/file/ScxQQeqilNPokwTCaG6okn/RelativeTime-(FY23-Q1)?node-id=218%3A2711
👁️ Preview: https://primer-a7c04617fa-26441320.drafts.github.io/components/relative-time