Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light theme shouldn't set tab.activeBorder as white #188

Closed
Tyriar opened this issue Jul 18, 2021 · 1 comment · Fixed by #189
Closed

Light theme shouldn't set tab.activeBorder as white #188

Tyriar opened this issue Jul 18, 2021 · 1 comment · Fixed by #189

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Jul 18, 2021

tab.activeBorder is set to #ffffff which doesn't actually do anything on the tab:

Screen Shot 2021-07-18 at 4 13 46 PM

For the newly added style to terminal tabs though it looks a bit weird:

Screen Shot 2021-07-18 at 4 14 05 PM

Notice the white line on the left.

To clarify what this theme key does, here it is in #ff0000

Screen Shot 2021-07-18 at 4 14 28 PM

Screen Shot 2021-07-18 at 4 14 34 PM
@Tyriar
Copy link
Contributor Author

Tyriar commented Jul 18, 2021

Setting "terminal.tab.activeBorder": "#f9826c" is probably a good solution here to match tab.activeBorderTop:

Screen Shot 2021-07-18 at 4 17 37 PM

Tyriar added a commit to Tyriar/github-vscode-theme that referenced this issue Jul 18, 2021
@Tyriar
Set terminal.tab.activeBorder based on editor tab
6d853bd 
Fixes primer#188
@Tyriar Tyriar mentioned this issue Jul 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set terminal.tab.activeBorder based on editor tab Tyriar/github-vscode-theme
1 participant
@Tyriar