New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set terminal.tab.activeBorder based on editor tab #189
Conversation
@@ -178,6 +178,7 @@ function getTheme({ style, name }) { | |||
"panelInput.border": pick({ light: primer.gray[2], dark: primer.gray[1] }), | |||
|
|||
"terminal.foreground": primer.gray[6], | |||
"terminal.tab.activeBorder": "#f9826c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not reproduce this change:
I also can not find this attribute in the VSCode Theme Color Documentation. Is this a user setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in Insiders only right now, coming in the next version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution. can you please provide a link to the documentation for the insiders build in this PR comments so we can reference it? 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no documentation yet, here's where it's declared in code though:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in Insiders only right now, coming in the next version
Thanks for clarifying. I think this should be fine to already merge. 👍
🗒️ Just a note to the maintainer who merges this PR. This change affects the insiders build of VSCode. No effects of this change can be observed in stable release builds yet. |
@@ -178,6 +178,7 @@ function getTheme({ style, name }) { | |||
"panelInput.border": pick({ light: primer.gray[2], dark: primer.gray[1] }), | |||
|
|||
"terminal.foreground": primer.gray[6], | |||
"terminal.tab.activeBorder": "#f9826c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in Insiders only right now, coming in the next version
Thanks for clarifying. I think this should be fine to already merge. 👍
Fixes #188