Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set terminal.tab.activeBorder based on editor tab #189

Merged
merged 1 commit into from Aug 9, 2021

Conversation

Tyriar
Copy link
Contributor

@Tyriar Tyriar commented Jul 18, 2021

Fixes #188

@@ -178,6 +178,7 @@ function getTheme({ style, name }) {
"panelInput.border": pick({ light: primer.gray[2], dark: primer.gray[1] }),

"terminal.foreground": primer.gray[6],
"terminal.tab.activeBorder": "#f9826c",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not reproduce this change:

screenshot-Mon-19Jul21_01 15

I also can not find this attribute in the VSCode Theme Color Documentation. Is this a user setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in Insiders only right now, coming in the next version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution. can you please provide a link to the documentation for the insiders build in this PR comments so we can reference it? 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in Insiders only right now, coming in the next version

Thanks for clarifying. I think this should be fine to already merge. 👍

@dominicegginton
Copy link
Contributor

🗒️ Just a note to the maintainer who merges this PR. This change affects the insiders build of VSCode. No effects of this change can be observed in stable release builds yet.

@@ -178,6 +178,7 @@ function getTheme({ style, name }) {
"panelInput.border": pick({ light: primer.gray[2], dark: primer.gray[1] }),

"terminal.foreground": primer.gray[6],
"terminal.tab.activeBorder": "#f9826c",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in Insiders only right now, coming in the next version

Thanks for clarifying. I think this should be fine to already merge. 👍

@simurai simurai merged commit a00f340 into primer:master Aug 9, 2021
@Tyriar Tyriar deleted the patch-1 branch August 9, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light theme shouldn't set tab.activeBorder as white
3 participants