Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IssueLabelToken has extremely low contrast in high contrast color modes #3098

Closed
iansan5653 opened this issue Mar 30, 2023 · 0 comments · Fixed by #3104
Closed

IssueLabelToken has extremely low contrast in high contrast color modes #3098

iansan5653 opened this issue Mar 30, 2023 · 0 comments · Fixed by #3104
Labels
accessibility bug Something isn't working component: Token react

Comments

@iansan5653
Copy link
Contributor

Description

The IssueLabelToken component looks fine in most color modes, but is broken in high contrast modes.

For example, the dark gray token from the Storybook looks like this in light mode:

screenshot of dark gray issue label with black text

But in high contrast mode it looks disabled:

screenshot of light gray issue label with light gray text

Here is another example, live (!) in Projects:

screenshot of blue and purple labels in Projects appearing washed out and faded

Steps to reproduce

Go to this story link

Version

v35.23.0

Browser

Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility bug Something isn't working component: Token react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IssueLabelToken treating alternative light schemes as dark primer/react
2 participants
@iansan5653 @primer-css