Add hover state to IssueLabelToken
#3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a8de9fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
lukasoppermann
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
@langermank I think the way it was set up does not work. Due to the gradient overlaying the bg, the I replaced this now with an overlay for light and a hsla color change for dark mode. That should fix it for now. It will never be as good as with predefined colors that have pre-defined hover colors though. |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
interactive-token-state
branch
from
7700292
to
39ce8f5
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
approved these changes
Apr 12, 2023
This was referenced Apr 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most elegant solution for adding state to user generated colors is probably to use the upcoming
color-mix()function. It doesn't have full browser support yet, so I added a fallback usingbackground-imagewith alinear-gradient.This is just a draft/prototype as I think it needs some fine tuning.
Closes #3072
Screenshots
CleanShot.2023-04-03.at.11.59.42.mp4
Merge checklist