-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover state to IssueLabelToken
#3112
Conversation
🦋 Changeset detectedLatest commit: a8de9fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@langermank I think the way it was set up does not work. Due to the gradient overlaying the bg, the I replaced this now with an overlay for light and a hsla color change for dark mode. That should fix it for now. It will never be as good as with predefined colors that have pre-defined hover colors though. |
7700292
to
39ce8f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great in Storybook 🚀
The most elegant solution for adding state to user generated colors is probably to use the upcoming
color-mix()
function. It doesn't have full browser support yet, so I added a fallback usingbackground-image
with alinear-gradient
.This is just a draft/prototype as I think it needs some fine tuning.
Closes #3072
Screenshots
CleanShot.2023-04-03.at.11.59.42.mp4
Merge checklist