Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #3106

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Release tracking #3106

merged 1 commit into from
Apr 19, 2023

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Mar 31, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@35.25.0

Minor Changes

Patch Changes

  • #3124 5b3cf499 Thanks @mattcosta7! - replace createRef with useRef

  • #3149 4c2d121f Thanks @colebemis! - FormControl is now SSR-compatible.

    Warning: In this new implementation, FormControl.Caption, FormControl.Label, FormControl.LeadingVisual, and FormControl.Validation must be direct children of FormControl.

  • #3114 f5c7f299 Thanks @radglob! - Adds the option to declare multiple segments in a ProgressBar.

  • #3127 5224fcbf Thanks @siddharthkp! - Suppress SSR warning for useLayoutEffect in NavList, use useIsomorphicLayoutEffect instead of useLayoutEffect

  • #3165 d749f495 Thanks @broccolinisoup! - UnderlineNav2: Add transparent outline for focus to support WHCM

  • #3120 9e40fdf4 Thanks @simurai! - Bump @primer/primitives to 7.11.5

  • #3093 8b5307da Thanks @simurai! - Bump @primer/primitives to 7.11.3

  • #3097 a38c00e6 Thanks @colebemis! - TreeView is now SSR-compatible.

    Warning: In this new implementation, TreeView.LeadingVisual and TreeView.TrailingView must be direct children of TreeView.Item.

  • #3170 1f2df9b7 Thanks @lukasoppermann! - When an inline description is added to the item the normal text is set to bold

  • #3160 4b05b19e Thanks @joshblack! - Update PageLayout.Pane to provide a warning instead of an error when overflow is detected and no label has been provided

  • #3094 16cae51a Thanks @mperrotti! - Fixes styling issue where PointerBox would show a border between the caret and the box if the background color was transparent.

  • #3112 bd4e1393 Thanks @langermank! - Adds shadow and color change to IssueLabelToken on hover

  • #3146 a19b721c Thanks @colebemis! - CheckboxGroup and RadioGroup are now SSR-compatible.

    Warning: In this new implementation, CheckboxGroup.Caption, CheckboxGroup.Label, and CheckboxGroup.Validation must be direct children of CheckboxGroup. The same applies to RadioGroup.

@primer-css primer-css requested review from a team and colebemis March 31, 2023 19:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Docs and Storybook open in a browser
  • Successful integration test with GitHub Projects as a primary consumer of Primer React
    • Install the Release Candidate
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Verify no new browser console errors appear
    • Verify unit tests and E2E tests pass
    • Manually test critical paths (Tip: Use the provided tests project boards)
    • Manually test release-specific bugfixes and/or features work as described
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Sanity test

  • All bugfixes in this release have resolved their corrosponding issues
  • All new features in this release have been tested and verified as compatible with GitHub Projects
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.61 KB (0%)
dist/browser.umd.js 96.17 KB (0%)

@primer-css primer-css temporarily deployed to github-pages March 31, 2023 19:46 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 March 31, 2023 19:46 Inactive
@primer-css primer-css temporarily deployed to github-pages March 31, 2023 21:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 March 31, 2023 21:18 Inactive
@primer-css primer-css temporarily deployed to github-pages April 3, 2023 14:40 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 3, 2023 14:41 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch 4 times, most recently from 80aa9f0 to 7c6a28a Compare April 3, 2023 18:26
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 3, 2023 18:37 Inactive
@primer-css primer-css temporarily deployed to github-pages April 3, 2023 18:47 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 3, 2023 18:47 Inactive
@primer-css primer-css temporarily deployed to github-pages April 3, 2023 20:27 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 3, 2023 20:28 Inactive
@primer-css primer-css temporarily deployed to github-pages April 3, 2023 21:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 3, 2023 21:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 00:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 15:23 Inactive
@primer primer bot temporarily deployed to github-pages April 18, 2023 15:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 15:24 Inactive
@primer-css primer-css temporarily deployed to github-pages April 18, 2023 15:33 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 15:33 Inactive
@primer-css primer-css temporarily deployed to github-pages April 18, 2023 16:25 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 16:25 Inactive
@primer-css primer-css temporarily deployed to github-pages April 18, 2023 19:14 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 19:15 Inactive
@primer-css primer-css temporarily deployed to github-pages April 18, 2023 19:20 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 19:21 Inactive
@primer-css primer-css temporarily deployed to github-pages April 18, 2023 19:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3106 April 18, 2023 19:33 Inactive
@colebemis colebemis merged commit 14c00e7 into main Apr 19, 2023
@colebemis colebemis deleted the changeset-release/main branch April 19, 2023 23:16
radglob pushed a commit that referenced this pull request Apr 20, 2023
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
radglob added a commit that referenced this pull request Apr 24, 2023
#2878)

* Render ActionList.Group header inside list, use li for semantic HTML reasons.

* Update snapshots.

* Fix snapshot. No idea why this isn't being generated correctly.

* Separate Heading from ActionList.Group.

Also made some styling changes (ex. no vertical padding on ActionList
<ul>) to align with PVC implementation.

* removed usage of actionlist.group.

* Fix type errors.

* Create modern-coins-destroy.md

* Fix ActionList.docs.json to fix components build CI step.

* Update generated/components.json

* test(vrt): update snapshots

* test(vrt): update snapshots

* Update snapshots.

* Update themePreval snapshot and cache bust file.

* Updated snapshots.

* Revert padding on ActionList.

* test(vrt): update snapshots

* Make sure lists are surrounded by a div, fix accessibility issues in Storybook.

* Updated snapshots, fix linting error.

* Update docs.

* Update generated/components.json

* Fix linting issues.

* Fixing some issues after the previous merge.

* Fix ActionMenu feature stories.

* Updated snapshots that shouldn't be different from main.

* disable axe check

* Update changeset to major patch instead of minor.

* re-gen test

* Add missing selectionVariant to Groups and Descriptions ActionMenu story.

* test(vrt): update snapshots

* Fix styling of ActionList to match prod.

* Fix linting errors in ActionList.

* test(vrt): update snapshots

* Reduce padding between ActionLists in ActionMenu example.

* refactor(DataTable): update optional type signatures (#2987)

* refactor(DataTable): update optional type signatures

* chore: update docs and add stories to json for DataTable

* chore: remove default story

* Update generated/components.json

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Textarea stories (#2988)

* checkbox

* Update generated/components.json

* tests

* Update generated/components.json

* fix docs

* radio stories

* Update generated/components.json

* fix doc

* remove axe

* add sb tests

* select

* add features

* e2e

* text input

* Update generated/components.json

* tokens

* Update generated/components.json

* tokens

* textarea

* all the things

* Update generated/components.json

* remove animation test

* test(vrt): update snapshots

* remove dead files

* Update generated/components.json

* missing exports

---------

Co-authored-by: langermank <langermank@users.noreply.github.com>

* Pagination design updates (#2702)

* updates pagination styles to match latest token usage patterns, and updates ARIA markup

* adds changeset

* Create .changeset/long-bags-double.md

---------

Co-authored-by: Cole Bemis <colebemis@github.com>

* Make sure ActionList.Heading titles are bolded correctly.

* Updated snapshots.

* Revert title font weight to semibold.

* Update snapshots.

* test(vrt): update snapshots

* Passing sxProps to ActionList.Heading through ActionList.

* More snapshot fiddling.

* Formatting.

* Use margin and padding to get spacing correct.

* Fix aat tests.

* Update snapshots.

* I think this should get the ActionMenu example back to what is expected.

* Revert "test(vrt): update snapshots"

This reverts commit a02012b.

* Revert "test(vrt): update snapshots"

This reverts commit a713875.

* Revert "test(vrt): update snapshots"

This reverts commit 2eae060.

* Revert "test(vrt): update snapshots"

This reverts commit bf59217.

* Revert "test(vrt): update snapshots"

This reverts commit 1c11a1b.

* Revert "test(vrt): update snapshots"

This reverts commit a02012b.

* Revert "test(vrt): update snapshots"

This reverts commit bf59217.

* Fix underlinenav.

* Updated snapshots.

* test(vrt): update snapshots

* Dialog v2: Move files, reformat stories and add e2e tests (#2984)

* initial

* Dialog v2: move files, refaormat stories and add e2e tests

* Update generated/components.json

* snaps

* remove jest disable

* Dialogv2 -> Dialog2

* storybook tests and await dialogs

* disable animations

* disable animations on the first snapshots too

* fix page locators

* test(vrt): update snapshots

* test(Hidden): update export

* Revert "test(Hidden): update export"

This reverts commit f29edd9.

---------

Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* feat(project): add warning, invariant utilities and dev-expression plugin (#2901)

* chore(project): add warning utility and dev-expression plugin

* chore: address eslint violations

* feat: add invariant and warn helper

* chore: flip flag for useMedia warning

* chore: add changeset

* chore: add minified exception case for invariant

* chore: update type signature for invariant

* test: update test for warning helper

* refactor(hooks): update useControllableState warning usage

* test(warning): update test titles with flipped condition

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* chore(deps-dev): bump mdast-util-to-string from 3.1.0 to 3.1.1 (#3018)

Bumps [mdast-util-to-string](https://github.com/syntax-tree/mdast-util-to-string) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/syntax-tree/mdast-util-to-string/releases)
- [Commits](syntax-tree/mdast-util-to-string@3.1.0...3.1.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-string
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump jscodeshift from 0.13.0 to 0.14.0 (#3015)

Bumps [jscodeshift](https://github.com/facebook/jscodeshift) from 0.13.0 to 0.14.0.
- [Release notes](https://github.com/facebook/jscodeshift/releases)
- [Changelog](https://github.com/facebook/jscodeshift/blob/main/CHANGELOG.md)
- [Commits](facebook/jscodeshift@0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: jscodeshift
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* chore(deps-dev): bump @babel/cli from 7.19.3 to 7.21.0 (#3016)

Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.19.3 to 7.21.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-cli)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* Add argTypes for HeadingPlayground ActionList story.

* Add aria-busy declaration in relevant story instead of in component.

* Update snapshots.

* Recalculate autocomplete suggestions if the input data changes while the menu is open (#3009)

* Add support for custom emoji suggestions

* Allow declaratively setting suggestions as "loading"

* Recalculate suggestions on update

* Create .changeset/silly-plants-draw.md

* Fix bug where page would be unresponsive if no suggestions provided

* docs(DataTable): add reference stories for row actions (#2978)

* docs(DataTable): add reference stories for row actions

* chore: clean-up ts types

* fix: add guards for optional id and field

* docs: add story ids to DataTable docs json

* Update generated/components.json

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* chore(deps): update babel dependencies (#3005)

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* feat(DataTable): add support for alphanumeric, datatable, and custom sort functions (#3001)

* chore: check-in work

* chore: clean-up work

* Update generated/components.json

* docs: add custom sorting story

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Add new usage instructions to changeset.

* Move ActionList.Group to versioned deprecated directory.

* Fix references in deprecated ActionList.Group.

* Fix themePreval snapshot.

* Update src/ActionList/ActionList.stories.tsx

Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>

* Update src/ActionList/ActionList.stories.tsx

Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>

* Heading playground only uses heading props.

* Use Box instead of styled elements for ActionList.Heading.

* Remove presentation role and aria-hidden from ActionList.Heading.

* Updated snapshot.

* Use restricted as prop instead of headingLevel.

* Use slots and contexts to allow developers to declare Heading like a child while still rendering correctly.

* Linting.

* Add @deprecated tag to ActionList.Group as first step towards deprecating component.

* Fix type errors in ActionMenu and ActionList stories.

* Formatting.

* Updated snapshots.

* Updating snapshots with --no-cache flag.

* Update docs, fix missing Group export on ActionList.

* Terminate comment correctly.

* Regenerate ActionMenu e2e tests.

* Add padding to fix snapshot diff.

* Change padding again.

* Remove extra padding.

* Add small amount of margin (not padding) to fix snapshot diff.

* Less margin.

* More margin, actually.

* I think this should work.

* I think this is the correct margin, something else is off.

* .

* These snapshot comparisons are confusing me.

* Just a little more margin.

* Ugh.

* test(vrt): update snapshots

* Slightly less margin.

* More tweaking.

* More tweaking.

* Disable animations on actionmenu test to see if it helps generate the snapshot correctly.

* test(vrt): update snapshots

* Don't animate Multiple Sections e2e test.

* Format file.

* test(vrt): update snapshots

* Revert snapshots to match main.

* Update snapshots again.

* Build snapshots without cache.

* Remove lingering references to headingProps.

* Update generated/components.json

* chore(deps): bump react-intersection-observer from 9.4.1 to 9.4.3 (#3177)

Bumps [react-intersection-observer](https://github.com/thebuilder/react-intersection-observer) from 9.4.1 to 9.4.3.
- [Release notes](https://github.com/thebuilder/react-intersection-observer/releases)
- [Commits](thebuilder/react-intersection-observer@v9.4.1...v9.4.3)

---
updated-dependencies:
- dependency-name: react-intersection-observer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump jest-fail-on-console from 3.0.2 to 3.1.1 (#3180)

Bumps [jest-fail-on-console](https://github.com/ValentinH/jest-fail-on-console) from 3.0.2 to 3.1.1.
- [Release notes](https://github.com/ValentinH/jest-fail-on-console/releases)
- [Commits](ValentinH/jest-fail-on-console@v3.0.2...v3.1.1)

---
updated-dependencies:
- dependency-name: jest-fail-on-console
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump unist-util-find-before from 3.0.0 to 3.0.1 (#3179)

Bumps [unist-util-find-before](https://github.com/syntax-tree/unist-util-find-before) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/syntax-tree/unist-util-find-before/releases)
- [Commits](syntax-tree/unist-util-find-before@3.0.0...3.0.1)

---
updated-dependencies:
- dependency-name: unist-util-find-before
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(PageLayout): update Pane to warn instead of error (#3160)

* fix(PageLayout): update Pane to warn instead of error

* chore: add changeset

* chore: remove invariant

* chore: address eslint violations

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Refactor(PageLayout): use Playwright for interaction tests instead of Storybook. (#3171)

* Change PageLayout interactions to use Playwright.

* Build snapshots without cache.

* Fix PageLayout.test.ts to use Page object because document is not defined.

* Pass missing page parameter to isInViewPort function.

* test(vrt): update snapshots

* Add tabIndex to PullRequestPage test so it is a scrollable region.

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Delete docs migration-related code (#3187)

* Delete docs_migration.yml

* Delete docs-migration.js

* Delete props-mdx-to-json.mjs

* Docs(Tooltip): Adds `defaultValue` of tooltip direction to documentation (#3175)

* docs: adds defaultValue of tooltip direction to documentation

* remove the changeset

* chore(project): update test-e2e docker image (#3183)

* feat(project): add subpath pattern to package.json to restrict internal imports (#3186)

* feat(project): add subpath pattern to package.json to restrict internal imports

* refactor(project): move useOverflow to internal/hooks

* docs(adrs): update adopted status for adr

* chore: add changeset

* Update generated/components.json

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Ensure disabled invisible buttons have the right text color. (#3185)

* Set disabled invisible button color similarly to other button variants.

* Don't set [data-no-visual=true] on invisible button variants.

* Update snapshots.

* Formatting and linting.

* test(vrt): update snapshots

* Update generated/components.json

* chore(project): update test-e2e docker image (#3183)

* Use selector to set disabled invisible button text color correctly.

* test(vrt): update snapshots

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* Refactor(Overlay): move files to folder. (#3191)

* Move overlay files to directory, move all stories to features as there isn't a clear default.

* Update generated/components.json

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Refactor(Text): move files to directory, add storybook and e2e tests. (#3189)

* Move Text files into directory, create storybook and e2e tests.

* Fix Text reference in src/index.ts, update snapshots.

* Update generated/components.json

* test(vrt): update snapshots

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Reduce ❌ for forks (#2283)

* Limit deploy to has pages

* Limit statuses to primer/react

* Limit stale to primer/react

* Preview cross org forks

---------

Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: Rez <rezrah@github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* Setup snapshots for visual regression for  experimental/Button2 (#3181)

* duplicate button into drafts

* update story title

* add visual tests for Button2

* test(vrt): update snapshots

---------

Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>

* Version Packages (#3106)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bug fix: `ButtonGroup` borders (#3198)

* fix hover borders

* Create wicked-knives-sparkle.md

* snaps

* why so many snaps?

* revert?

* test(vrt): update snapshots

---------

Co-authored-by: langermank <langermank@users.noreply.github.com>

* Refactor(Portal): move stories into Portal directory. (#3188)

* Move portal stories to portal directory.

* Reorganize portal stories into separate files for default and features.

* Generate e2e tests for portal components.

* Update generated/components.json

* Remove e2e portal tests as they do not play well with Playwright.

* Remove unnecessary decorator from story metadata.

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Use SSR-compatible slot implementation in ActionList/NavList (#3173)

* Migrate ActionList to use new slots impl

* Remove ActionList slots

* Remove unused import

* Create lemon-berries-run.md

* Update snapshots

* Fix slot description logic

* Fix style logic

* Fix conditional box logic

* Fix aria-labelledby logic

* Fix flexbox logic

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: radglob <radglob@users.noreply.github.com>
Co-authored-by: langermank <18661030+langermank@users.noreply.github.com>
Co-authored-by: joshblack <joshblack@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: langermank <langermank@users.noreply.github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Armağan <broccolinisoup@github.com>
Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Sanders <iansan5653@github.com>
Co-authored-by: Ederson Lucas <27015559+edersonlucas@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Rez <rezrah@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Co-authored-by: GitHub Design Systems Bot <30705008+primer-css@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
broccolinisoup added a commit that referenced this pull request Jun 21, 2023
#2878)

* Render ActionList.Group header inside list, use li for semantic HTML reasons.

* Update snapshots.

* Fix snapshot. No idea why this isn't being generated correctly.

* Separate Heading from ActionList.Group.

Also made some styling changes (ex. no vertical padding on ActionList
<ul>) to align with PVC implementation.

* removed usage of actionlist.group.

* Fix type errors.

* Create modern-coins-destroy.md

* Fix ActionList.docs.json to fix components build CI step.

* Update generated/components.json

* test(vrt): update snapshots

* test(vrt): update snapshots

* Update snapshots.

* Update themePreval snapshot and cache bust file.

* Updated snapshots.

* Revert padding on ActionList.

* test(vrt): update snapshots

* Make sure lists are surrounded by a div, fix accessibility issues in Storybook.

* Updated snapshots, fix linting error.

* Update docs.

* Update generated/components.json

* Fix linting issues.

* Fixing some issues after the previous merge.

* Fix ActionMenu feature stories.

* Updated snapshots that shouldn't be different from main.

* disable axe check

* Update changeset to major patch instead of minor.

* re-gen test

* Add missing selectionVariant to Groups and Descriptions ActionMenu story.

* test(vrt): update snapshots

* Fix styling of ActionList to match prod.

* Fix linting errors in ActionList.

* test(vrt): update snapshots

* Reduce padding between ActionLists in ActionMenu example.

* refactor(DataTable): update optional type signatures (#2987)

* refactor(DataTable): update optional type signatures

* chore: update docs and add stories to json for DataTable

* chore: remove default story

* Update generated/components.json

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Textarea stories (#2988)

* checkbox

* Update generated/components.json

* tests

* Update generated/components.json

* fix docs

* radio stories

* Update generated/components.json

* fix doc

* remove axe

* add sb tests

* select

* add features

* e2e

* text input

* Update generated/components.json

* tokens

* Update generated/components.json

* tokens

* textarea

* all the things

* Update generated/components.json

* remove animation test

* test(vrt): update snapshots

* remove dead files

* Update generated/components.json

* missing exports

---------

Co-authored-by: langermank <langermank@users.noreply.github.com>

* Pagination design updates (#2702)

* updates pagination styles to match latest token usage patterns, and updates ARIA markup

* adds changeset

* Create .changeset/long-bags-double.md

---------

Co-authored-by: Cole Bemis <colebemis@github.com>

* Make sure ActionList.Heading titles are bolded correctly.

* Updated snapshots.

* Revert title font weight to semibold.

* Update snapshots.

* test(vrt): update snapshots

* Passing sxProps to ActionList.Heading through ActionList.

* More snapshot fiddling.

* Formatting.

* Use margin and padding to get spacing correct.

* Fix aat tests.

* Update snapshots.

* I think this should get the ActionMenu example back to what is expected.

* Revert "test(vrt): update snapshots"

This reverts commit a02012b.

* Revert "test(vrt): update snapshots"

This reverts commit a713875.

* Revert "test(vrt): update snapshots"

This reverts commit 2eae060.

* Revert "test(vrt): update snapshots"

This reverts commit bf59217.

* Revert "test(vrt): update snapshots"

This reverts commit 1c11a1b.

* Revert "test(vrt): update snapshots"

This reverts commit a02012b.

* Revert "test(vrt): update snapshots"

This reverts commit bf59217.

* Fix underlinenav.

* Updated snapshots.

* test(vrt): update snapshots

* Dialog v2: Move files, reformat stories and add e2e tests (#2984)

* initial

* Dialog v2: move files, refaormat stories and add e2e tests

* Update generated/components.json

* snaps

* remove jest disable

* Dialogv2 -> Dialog2

* storybook tests and await dialogs

* disable animations

* disable animations on the first snapshots too

* fix page locators

* test(vrt): update snapshots

* test(Hidden): update export

* Revert "test(Hidden): update export"

This reverts commit f29edd9.

---------

Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* feat(project): add warning, invariant utilities and dev-expression plugin (#2901)

* chore(project): add warning utility and dev-expression plugin

* chore: address eslint violations

* feat: add invariant and warn helper

* chore: flip flag for useMedia warning

* chore: add changeset

* chore: add minified exception case for invariant

* chore: update type signature for invariant

* test: update test for warning helper

* refactor(hooks): update useControllableState warning usage

* test(warning): update test titles with flipped condition

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* chore(deps-dev): bump mdast-util-to-string from 3.1.0 to 3.1.1 (#3018)

Bumps [mdast-util-to-string](https://github.com/syntax-tree/mdast-util-to-string) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/syntax-tree/mdast-util-to-string/releases)
- [Commits](syntax-tree/mdast-util-to-string@3.1.0...3.1.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-string
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump jscodeshift from 0.13.0 to 0.14.0 (#3015)

Bumps [jscodeshift](https://github.com/facebook/jscodeshift) from 0.13.0 to 0.14.0.
- [Release notes](https://github.com/facebook/jscodeshift/releases)
- [Changelog](https://github.com/facebook/jscodeshift/blob/main/CHANGELOG.md)
- [Commits](facebook/jscodeshift@0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: jscodeshift
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* chore(deps-dev): bump @babel/cli from 7.19.3 to 7.21.0 (#3016)

Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.19.3 to 7.21.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-cli)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* Add argTypes for HeadingPlayground ActionList story.

* Add aria-busy declaration in relevant story instead of in component.

* Update snapshots.

* Recalculate autocomplete suggestions if the input data changes while the menu is open (#3009)

* Add support for custom emoji suggestions

* Allow declaratively setting suggestions as "loading"

* Recalculate suggestions on update

* Create .changeset/silly-plants-draw.md

* Fix bug where page would be unresponsive if no suggestions provided

* docs(DataTable): add reference stories for row actions (#2978)

* docs(DataTable): add reference stories for row actions

* chore: clean-up ts types

* fix: add guards for optional id and field

* docs: add story ids to DataTable docs json

* Update generated/components.json

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* chore(deps): update babel dependencies (#3005)

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* feat(DataTable): add support for alphanumeric, datatable, and custom sort functions (#3001)

* chore: check-in work

* chore: clean-up work

* Update generated/components.json

* docs: add custom sorting story

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Add new usage instructions to changeset.

* Move ActionList.Group to versioned deprecated directory.

* Fix references in deprecated ActionList.Group.

* Fix themePreval snapshot.

* Update src/ActionList/ActionList.stories.tsx

Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>

* Update src/ActionList/ActionList.stories.tsx

Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>

* Heading playground only uses heading props.

* Use Box instead of styled elements for ActionList.Heading.

* Remove presentation role and aria-hidden from ActionList.Heading.

* Updated snapshot.

* Use restricted as prop instead of headingLevel.

* Use slots and contexts to allow developers to declare Heading like a child while still rendering correctly.

* Linting.

* Add @deprecated tag to ActionList.Group as first step towards deprecating component.

* Fix type errors in ActionMenu and ActionList stories.

* Formatting.

* Updated snapshots.

* Updating snapshots with --no-cache flag.

* Update docs, fix missing Group export on ActionList.

* Terminate comment correctly.

* Regenerate ActionMenu e2e tests.

* Add padding to fix snapshot diff.

* Change padding again.

* Remove extra padding.

* Add small amount of margin (not padding) to fix snapshot diff.

* Less margin.

* More margin, actually.

* I think this should work.

* I think this is the correct margin, something else is off.

* .

* These snapshot comparisons are confusing me.

* Just a little more margin.

* Ugh.

* test(vrt): update snapshots

* Slightly less margin.

* More tweaking.

* More tweaking.

* Disable animations on actionmenu test to see if it helps generate the snapshot correctly.

* test(vrt): update snapshots

* Don't animate Multiple Sections e2e test.

* Format file.

* test(vrt): update snapshots

* Revert snapshots to match main.

* Update snapshots again.

* Build snapshots without cache.

* Remove lingering references to headingProps.

* Update generated/components.json

* chore(deps): bump react-intersection-observer from 9.4.1 to 9.4.3 (#3177)

Bumps [react-intersection-observer](https://github.com/thebuilder/react-intersection-observer) from 9.4.1 to 9.4.3.
- [Release notes](https://github.com/thebuilder/react-intersection-observer/releases)
- [Commits](thebuilder/react-intersection-observer@v9.4.1...v9.4.3)

---
updated-dependencies:
- dependency-name: react-intersection-observer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump jest-fail-on-console from 3.0.2 to 3.1.1 (#3180)

Bumps [jest-fail-on-console](https://github.com/ValentinH/jest-fail-on-console) from 3.0.2 to 3.1.1.
- [Release notes](https://github.com/ValentinH/jest-fail-on-console/releases)
- [Commits](ValentinH/jest-fail-on-console@v3.0.2...v3.1.1)

---
updated-dependencies:
- dependency-name: jest-fail-on-console
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump unist-util-find-before from 3.0.0 to 3.0.1 (#3179)

Bumps [unist-util-find-before](https://github.com/syntax-tree/unist-util-find-before) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/syntax-tree/unist-util-find-before/releases)
- [Commits](syntax-tree/unist-util-find-before@3.0.0...3.0.1)

---
updated-dependencies:
- dependency-name: unist-util-find-before
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(PageLayout): update Pane to warn instead of error (#3160)

* fix(PageLayout): update Pane to warn instead of error

* chore: add changeset

* chore: remove invariant

* chore: address eslint violations

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Refactor(PageLayout): use Playwright for interaction tests instead of Storybook. (#3171)

* Change PageLayout interactions to use Playwright.

* Build snapshots without cache.

* Fix PageLayout.test.ts to use Page object because document is not defined.

* Pass missing page parameter to isInViewPort function.

* test(vrt): update snapshots

* Add tabIndex to PullRequestPage test so it is a scrollable region.

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Delete docs migration-related code (#3187)

* Delete docs_migration.yml

* Delete docs-migration.js

* Delete props-mdx-to-json.mjs

* Docs(Tooltip): Adds `defaultValue` of tooltip direction to documentation (#3175)

* docs: adds defaultValue of tooltip direction to documentation

* remove the changeset

* chore(project): update test-e2e docker image (#3183)

* feat(project): add subpath pattern to package.json to restrict internal imports (#3186)

* feat(project): add subpath pattern to package.json to restrict internal imports

* refactor(project): move useOverflow to internal/hooks

* docs(adrs): update adopted status for adr

* chore: add changeset

* Update generated/components.json

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Ensure disabled invisible buttons have the right text color. (#3185)

* Set disabled invisible button color similarly to other button variants.

* Don't set [data-no-visual=true] on invisible button variants.

* Update snapshots.

* Formatting and linting.

* test(vrt): update snapshots

* Update generated/components.json

* chore(project): update test-e2e docker image (#3183)

* Use selector to set disabled invisible button text color correctly.

* test(vrt): update snapshots

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* Refactor(Overlay): move files to folder. (#3191)

* Move overlay files to directory, move all stories to features as there isn't a clear default.

* Update generated/components.json

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Refactor(Text): move files to directory, add storybook and e2e tests. (#3189)

* Move Text files into directory, create storybook and e2e tests.

* Fix Text reference in src/index.ts, update snapshots.

* Update generated/components.json

* test(vrt): update snapshots

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Reduce ❌ for forks (#2283)

* Limit deploy to has pages

* Limit statuses to primer/react

* Limit stale to primer/react

* Preview cross org forks

---------

Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: Rez <rezrah@github.com>
Co-authored-by: Josh Black <joshblack@github.com>

* Setup snapshots for visual regression for  experimental/Button2 (#3181)

* duplicate button into drafts

* update story title

* add visual tests for Button2

* test(vrt): update snapshots

---------

Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>

* Version Packages (#3106)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bug fix: `ButtonGroup` borders (#3198)

* fix hover borders

* Create wicked-knives-sparkle.md

* snaps

* why so many snaps?

* revert?

* test(vrt): update snapshots

---------

Co-authored-by: langermank <langermank@users.noreply.github.com>

* Refactor(Portal): move stories into Portal directory. (#3188)

* Move portal stories to portal directory.

* Reorganize portal stories into separate files for default and features.

* Generate e2e tests for portal components.

* Update generated/components.json

* Remove e2e portal tests as they do not play well with Playwright.

* Remove unnecessary decorator from story metadata.

---------

Co-authored-by: radglob <radglob@users.noreply.github.com>

* Use SSR-compatible slot implementation in ActionList/NavList (#3173)

* Migrate ActionList to use new slots impl

* Remove ActionList slots

* Remove unused import

* Create lemon-berries-run.md

* Update snapshots

* Fix slot description logic

* Fix style logic

* Fix conditional box logic

* Fix aria-labelledby logic

* Fix flexbox logic

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: radglob <radglob@users.noreply.github.com>
Co-authored-by: langermank <18661030+langermank@users.noreply.github.com>
Co-authored-by: joshblack <joshblack@users.noreply.github.com>
Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: langermank <langermank@users.noreply.github.com>
Co-authored-by: Mike Perrotti <mperrotti@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Armağan <broccolinisoup@github.com>
Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Sanders <iansan5653@github.com>
Co-authored-by: Ederson Lucas <27015559+edersonlucas@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Rez <rezrah@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Co-authored-by: GitHub Design Systems Bot <30705008+primer-css@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants