Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip design issues #2431

Closed
safeforge opened this issue Dec 8, 2023 · 1 comment
Closed

Tooltip design issues #2431

safeforge opened this issue Dec 8, 2023 · 1 comment
Labels

Comments

@safeforge
Copy link
Contributor

I have encountered an issue with the tooltip component and its usage after the upgrade from version 0.12.0 to 0.13.0, and it still persists in the latest version, 0.15.1. As evident from the screenshots, there is a significant difference between versions 0.12.0 and 0.13.0. I'm unsure if this discrepancy is related to the code introduced in #2284.

0.12.0
0 12 0

0.13.0
0 13 0

0.15.1
0 15 1

I've also tested using the demo application in version 0.15.1, and everything is functioning correctly. The primary difference in my application is that I'm using it in the package.json instead of the Gemfile.

Could someone guide me in the right direction?

@jonrohan
Copy link
Member

Hey, sorry you're having trouble with it. You'll need an extra dependency to get the css vars for this to work. @primer/primitives Is our cross library repo that holds all these values.

You will need to import them into your pipeline somewhere. Depending on your setup might be different instructions. Here's where we include these values in our demo app https://github.com/primer/view_components/blob/main/demo/app/assets/stylesheets/application.css#L4-L12 and for color themes https://github.com/primer/view_components/blob/main/demo/app/assets/stylesheets/primitives_v8.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants