default_obj_ of Device and Graph should be instantiated in one place. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this can be more easily to do. Will fix |
Signed-off-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>
mattn
force-pushed
the
fix-instantiate
branch
from
c7843c1
to
f3dfd3b
Compare
|
I changed this patch to NOT export default_obj_ to executable. I confirmed this works on Windows & Linux & FreeBSD.
I don't understand why duplicate symbol error not occured. |
|
@vbkaisetsu Please check if this change is consistent with #47 discussion. |
odashi
previously approved these changes
Dec 17, 2019
vbkaisetsu
requested changes
Dec 18, 2019
|
Thanks. Will look into it in later. |
|
All tests passed on Windows. |
|
This seems the change introduces another environment dependent behavior. I guessed we need to use some predefined macros by the Windows compilers (e.g., |
|
Make sense. Do you need some comments? |
|
It would be fine to put a link to this issue (and some short comments). |
vbkaisetsu
reviewed
Dec 19, 2019
mattn
force-pushed
the
fix-instantiate
branch
from
ee6af58
to
0776ade
Compare
mattn
force-pushed
the
fix-instantiate
branch
from
0776ade
to
6e29c77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of primitiv defines
default_obj_in header file device.h/graph.h.This works almost cases. But when building DLL&EXE on Windows,
default_obj_is instantiated in two places.`default_obj_` in the DLL is set via set_default but `default_obj_` in the executable always NOT be updated. So the Windows application using primitiv always crash when constructor of Parameter/Input/Node is called. To fix this issue, an instantiation of `default_obj_` should be at a place. This change remove the definitions of `default_obj_`. And `Device::default_obj_` and `Graph::default_obj_` are instantiated via definition of dummy function. These instances are embedded in DLL, and code of application do not need to use any hacks(ex: define PRIMITIV_MAKE_INSTANCE in main.cc) to instantiate them.I confirmed this works on Windows & Linux. Thanks.