Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A typo in Efficient Correlated layer #42

Closed
hzhang57 opened this issue Oct 4, 2020 · 3 comments
Closed

A typo in Efficient Correlated layer #42

hzhang57 opened this issue Oct 4, 2020 · 3 comments

Comments

@hzhang57
Copy link

hzhang57 commented Oct 4, 2020

fmap1_i = self.pyramid[0][0].permute(0, 2, 3, 1).contiguous()

Hi, should the 0 here be i?

fmap1_i = self.pyramid[0][0].permute(0, 2, 3, 1).contiguous() --> fmap1_i = self.pyramid[i][0].permute(0, 2, 3, 1).contiguous()

@zachteed
Copy link
Collaborator

zachteed commented Oct 5, 2020

Hi, I believe the current implementation is correct. If you look the equation on page 7 of our paper, only the second feature my is pooled, fmap1 is not pooled

@hzhang57
Copy link
Author

hzhang57 commented Oct 6, 2020

Thank you for detailed explanation, I miss understand the function.

@hzhang57 hzhang57 closed this as completed Oct 6, 2020
@vadimkantorov
Copy link

vadimkantorov commented Mar 13, 2021

@zachteed Then probably self.pyramid[i][0] should not even be computed for i > 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants