Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in cryo_project #61

Open
janden opened this issue Feb 8, 2018 · 2 comments
Open

Crash in cryo_project #61

janden opened this issue Feb 8, 2018 · 2 comments
Labels

Comments

@janden
Copy link
Contributor

janden commented Feb 8, 2018

Specifically, running it with double precision seems to crash it for certain NUFFT codes:

f = load(fullfile('projections', 'simulation', 'maps', 'cleanrib.mat'));
cryo_project(f.volref, eye(3), size(f.volref, 1), 'double');

says the imaginary component is too large. Here, it's about 13 times larger than precision and since imagtol is 5*precision, it fails.

What is the reason for having such a strict check on the imaginary components? When would this happen? We end up taking the real part afterwards anyhow.

@janden janden added the bug label Feb 8, 2018
@yoelsh
Copy link
Contributor

yoelsh commented Feb 8, 2018

This was supposed to be a safeguard against bugs.
I have simply never tested it in double precision...
In single precision and lower I never had problem.
I guess it should be fine even if we lose 2 digits, that is 100*precision.

@janden
Copy link
Contributor Author

janden commented Feb 12, 2018

Ok. Will make this a bit looser then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants