Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face-centered outputs are missing last entry #24

Closed
c-white opened this issue Sep 20, 2016 · 7 comments
Closed

Face-centered outputs are missing last entry #24

c-white opened this issue Sep 20, 2016 · 7 comments
Assignees
Labels
enhancement Improve an existing Athena++ component file IO Relating to writing/reading of .tab, .hdf5, .vtk, etc MHD Relating to components involving the B field wontfix No action planned
Milestone

Comments

@c-white
Copy link
Contributor

c-white commented Sep 20, 2016

The HDF5 output supports the face-centered fields, however it only writes nx3 * nx2 * nx1 values, rather than, e.g., nx3 * nx2 * (nx1+1) in the case of x1-faces.

@c-white c-white added the enhancement Improve an existing Athena++ component label Sep 20, 2016
@tomidakn
Copy link
Contributor

I was aware this but I did not change it intentionally. If we want to implement this, I guess the XDMF file must be modified to indicate it is a face-centered variable.

@felker
Copy link
Contributor

felker commented Mar 28, 2018

Is this still the case, @tomidakn ?

@tomidakn
Copy link
Contributor

Yes. I have not changed it. Actually, if we want to implement this, we should do it thoroughly so that VisIt (and other visualization software) can interpret those data points as face-centered, not volume-centered.

@felker felker added file IO Relating to writing/reading of .tab, .hdf5, .vtk, etc MHD Relating to components involving the B field wontfix No action planned labels Apr 12, 2018
@felker felker closed this as completed Apr 13, 2018
@felker felker reopened this Jul 25, 2018
@stale stale bot removed the wontfix No action planned label Jul 25, 2018
@felker felker self-assigned this Jul 25, 2018
@felker
Copy link
Contributor

felker commented Jul 25, 2018

@tomidakn, how complicated would it be to make the change suitable for VisIt?

@tomidakn
Copy link
Contributor

To be honest I do not know, and I am sorry but I do not want to spend too much time on VisIt. I'd appreciate if someone who really needs this feature could take care of it. Please take a look at the VisIt documentation.
https://wci.llnl.gov/content/assets/docs/simulation/computer-codes/visit/GettingDataIntoVisIt2.0.0.pdf

@felker
Copy link
Contributor

felker commented Jul 26, 2018

😆 I understand not wanting to spend too much time on VisIt. I could take a look.

@felker felker added this to the Future milestone Oct 9, 2018
@stale
Copy link

stale bot commented Jan 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix No action planned label Jan 7, 2019
@stale stale bot closed this as completed Jan 15, 2019
changgoo added a commit to changgoo/athena that referenced this issue Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing Athena++ component file IO Relating to writing/reading of .tab, .hdf5, .vtk, etc MHD Relating to components involving the B field wontfix No action planned
Projects
None yet
Development

No branches or pull requests

3 participants