Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FastTemplateModeler #29

Closed
jakevdp opened this issue Mar 30, 2017 · 2 comments
Closed

Rename FastTemplateModeler #29

jakevdp opened this issue Mar 30, 2017 · 2 comments

Comments

@jakevdp
Copy link
Collaborator

jakevdp commented Mar 30, 2017 •
edited
Loading

I think it would make sense to rename the top-level method to FastTemplatePeriodogram, to match the name of the package. Additionally, reading through the code I was initially confused by the names TemplateModel and FastTemplateModeler, because at first glance it sounds like the two classes should do the same thing, just at different speeds. A name change would prevent that confusion as well.

Thoughts?
@johnh2o2
Copy link
Collaborator

I've changed all Modeler instances to Periodogram instances.

@jakevdp
Copy link
Collaborator Author

jakevdp commented Apr 14, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakevdp @johnh2o2