Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated binaries + include in normal release #31

Closed
janpio opened this issue Dec 2, 2019 · 2 comments
Closed

Outdated binaries + include in normal release #31

janpio opened this issue Dec 2, 2019 · 2 comments
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug.
Milestone

Comments

@janpio
Copy link
Contributor

janpio commented Dec 2, 2019

This is not working in the extension as it is using an outdated URL for download . The right URL can be found in the binaries spec .

We should also make sure to bump the plugin version on each release to make sure that users always use a recent version of the prisma-fmt binary.

via prisma/prisma-engines#212 (comment)

@janpio janpio mentioned this issue Dec 2, 2019
3 tasks
@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. process/candidate Candidate for next Milestone. labels Dec 2, 2019
@janpio janpio added this to the Preview 18 milestone Dec 3, 2019
@janpio janpio removed the process/candidate Candidate for next Milestone. label Dec 3, 2019
@matthewmueller
Copy link
Contributor

matthewmueller commented Dec 3, 2019

Outdated binaries is fixed.

I'd suggest opening a separate issue for including in the normal release (or repurpose this issue). I sat down with Divy this morning and it's not as easy as it sounds. I'm not planning on working on that for Preview 18.

@janpio
Copy link
Contributor Author

janpio commented Dec 3, 2019

Thanks for the update, done via #34

@janpio janpio closed this as completed Dec 3, 2019
@matthewmueller matthewmueller removed their assignment Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug.
Projects
None yet
Development

No branches or pull requests

2 participants