Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all officially supported versions of Prisma in CI #69

Closed
jasonkuhrt opened this issue Jun 1, 2021 · 6 comments · Fixed by #117
Closed

Test all officially supported versions of Prisma in CI #69

jasonkuhrt opened this issue Jun 1, 2021 · 6 comments · Fixed by #117
Assignees
Labels
ci About our continuous integration pipelines community/help-wanted Not our focus, but accepting PRs type/tests Internal tests

Comments

@jasonkuhrt
Copy link
Contributor

jasonkuhrt commented Jun 1, 2021

What

  • We list multiple versions of Prisma in our peer dependency requirements
  • In CI we only test what is in our dev dependencies
  • This means we are not testing everything we claim to support

Why

  • Increase confidence both us and our users

How

  • gh matrix, prisma version dimension matching what we put into our peer dep package json value
  • install a version of prisma right before testing

Notes

  • This is going to get intense to test each combo of prisma/Node/OS... 😱
@jasonkuhrt jasonkuhrt added community/help-wanted Not our focus, but accepting PRs type/tests Internal tests ci About our continuous integration pipelines labels Jun 1, 2021
@jasonkuhrt
Copy link
Contributor Author

CC @janpio fyi thought you might find this one interesting

@janpio
Copy link

janpio commented Jun 1, 2021

Indeed 👍

I think you can limit Prisma version testing to one Node version, and potentially also OS as you are testing the current Prisma version on all of those and Prisma itself is being tested on all relevant Node versions and OS.

@jasonkuhrt
Copy link
Contributor Author

jasonkuhrt commented Jun 1, 2021

Does this sound good to you?

  • latest officially supported prisma on all node/OS combos
  • all trailing officially supported prisma versions on JUST latest LTS Node & ubuntu

@jasonkuhrt
Copy link
Contributor Author

jasonkuhrt commented Jun 1, 2021

Also: we should note in the docs that officially supporting a version of Prisma means only its latest patch version under that minor series. So yes 2.24.1 and NO 2.24.0, etc.

This detail reflects the testing strategy and thus keeps things more honest/accurate.

The implication is that if there is a bug with the combo of Nexus Prisma and 2.24.0 but NOT 2.24.1 then we wouldn't be obliged to do anything in Nexus Prisma.

@janpio
Copy link

janpio commented Jun 1, 2021

Yep, that all makes a lot of sense.

@jasonkuhrt jasonkuhrt pinned this issue Jul 8, 2021
@jasonkuhrt jasonkuhrt self-assigned this Aug 26, 2021
@jasonkuhrt jasonkuhrt unpinned this issue Aug 26, 2021
@rostislav-simonik-nexus-prisma-admin
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci About our continuous integration pipelines community/help-wanted Not our focus, but accepting PRs type/tests Internal tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants