Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Centralize SQL connection handling into central crate #109

Closed
mavilein opened this issue Oct 18, 2019 · 3 comments · Fixed by #162
Closed

Refactoring: Centralize SQL connection handling into central crate #109

mavilein opened this issue Oct 18, 2019 · 3 comments · Fixed by #162
Assignees
Milestone

Comments

@mavilein
Copy link
Contributor

Currently we have a lot of code duplication between the differnt SQL connectors that we have. We should create a new crate in our libs folder that compose prisma-query and all database drivers into a neat abstraction that can be used in all of our SQL connectors.

@do4gr and I disovered that when implementing the SQL introspection tests that required us to copy a ton of code from the SQL migration connector.

@mavilein
Copy link
Contributor Author

This is something that @tomhoule could tackle.

@tomhoule
Copy link
Contributor

Depending on when we tackle that problem, we may want to do it more or less at the same time as the move to asynchronous database access. prisma-query has lots of breaking changes in the async-await branch, so it will force us to rewrite the SQL connection handling anyway.

@janpio janpio added this to the Preview 16 milestone Oct 28, 2019
@tomhoule
Copy link
Contributor

tomhoule commented Nov 7, 2019

This is already partially done in master. Once #162 is merged, I think we can consider this issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants