Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build OS-based binaries instead of platform-based #37

Closed
4 tasks done
steebchen opened this issue Sep 10, 2019 · 1 comment
Closed
4 tasks done

Build OS-based binaries instead of platform-based #37

steebchen opened this issue Sep 10, 2019 · 1 comment
Assignees
Milestone

Comments

@steebchen
Copy link
Contributor

steebchen commented Sep 10, 2019

Currently, the rust binaries are built for specific platforms like netlify, zeit/now, etc.

Instead, we should build OS-based distributions with different openssl versions, because different operating systems ship with different default openssl versions.

We need:

  • debian-based builds with libssl 1.0.x and 1.1.x
    This will support all major debian versions, all major ubuntu versions, probably most or ever all debian and ubuntu based distributions (e.g. Linux Mint), and cloud platforms which run on Ubuntu like Netlify
  • centos builds with libssl 1.0.x and 1.1.x,

This will add proper support for:

  • CentOS 7
  • Debian 8, 9, 10
  • Ubuntu 14.04, 16.04, 18.04, 19.04
  • debian and ubuntu based distributions
  • Fedora 28-30
  • Most cloud platforms like zeit/now, netlify, lambda

Note: When these binares are shipped, we need to adapt the fetch-engine in photonjs. See #TODO for tracking.

When done, we can remove:

  • platform-specific builds like zeit, netlify, lambda, etc. when they work out of the box with the new OS-based builds
  • ubuntu16.04 because it was only built as a workaround

For a general overview, see prisma/prisma#533

@steebchen steebchen changed the title Build OS-based images instead of platform-based Build OS-based binaries instead of platform-based Sep 10, 2019
@janpio janpio added this to the Preview 17 milestone Nov 12, 2019
@janpio
Copy link
Contributor

janpio commented Nov 12, 2019

This is now done and can be implemented by TypeScript land.
That work is tracked in prisma/prisma#928 by @timsuchanek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants