fix: return type for findMany* should be non-nullable #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Internal Note: Find out original motivation for behaviour |
|
Hey @sameoldmadness 👋 , sorry for getting back so late to you. Thanks a lot for the PR 🙏 . I had to check internally whether we can actually change this, because we once had very important reasons to do it this way. But it turns out that this is not needed anymore. Could you fix the merge conflict please? Then i can merge it right away :-) |
sameoldmadness
force-pushed
the
find-many-return-type-should-be-non-nullable
branch
from
45e90fb
to
a067910
Compare
|
|
|
@mavilein done, thanks. |
mavilein
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes prisma-labs/graphql-framework-experiment#223