Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datamodel Parser: Native Types #71

Closed
mavilein opened this issue Sep 26, 2019 · 6 comments · Fixed by #1004
Closed

Datamodel Parser: Native Types #71

mavilein opened this issue Sep 26, 2019 · 6 comments · Fixed by #1004
Assignees
@carmenberndt
Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines Issue for tech Engines.
Milestone
Release 2.6.0

Comments

@mavilein
Copy link
Contributor

Check the related epic for an initial breakdown of work packages.

Please use supply a more detailed task list in a comment.
@janpio janpio mentioned this issue Sep 26, 2019
Closed
@yoshuawuyts yoshuawuyts changed the title Datamodel Parser: Custom Types Datamodel Parser: Native Types Jul 21, 2020
@mavilein mavilein added this to the Milestone 2.5.0 milestone Aug 6, 2020
@mavilein
Copy link
Contributor Author

mavilein commented Aug 7, 2020 •
edited by carmenberndt
Loading

  • core
    • proper feature flagging in lift.rs - add previewFeatures to Datasource - look at Generator
    • remove hardcoding of datasource name from lift.rs
    • add validation for number of arguments
    • add validation for placement on correct field type
    • implement rendering
  • native-types lib
    • finish definitions for MySQL
  • sql-datamodel-connector
    • finish implementation of Postgres
    • add implementation for MySQL

@mavilein
Copy link
Contributor Author

mavilein commented Aug 7, 2020

MSSQL and SQLite can be ignored for now. MSSQL is still in the works. SQLite maybe won't have any native type definitions.

@mavilein
Copy link
Contributor Author

mavilein commented Aug 7, 2020

Overview of types we want to support in the beginning: https://www.notion.so/prismaio/Type-Mappings-for-Native-Types-e475a3ce7a434e419144fe2cbfc38e63

@carmenberndt carmenberndt mentioned this issue Aug 11, 2020
Merged
@erawk erawk mentioned this issue Aug 13, 2020
Open
@mavilein mavilein added tech/engines Issue for tech Engines. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema labels Aug 18, 2020
@janpio janpio modified the milestones: Milestone 2.5.0, Backlog 2.6.0 Aug 18, 2020
@janpio janpio modified the milestones: Backlog 2.6.0, Release 2.6.0 Aug 19, 2020
@divideby0
Copy link

Just a heads up, the linked Notion doc is not public:

image

@janpio
Copy link
Contributor

janpio commented Sep 1, 2020

That is intentional @divideby0 while we develop this feature. When we are ready to talk about this in the open, we will also document the supported types of course.

@divideby0
Copy link

Noted, thank you. I've got about 5+ projects going between Prisma 1 and Prisma 2 so, if you're interested in some early-adopter feedback, I'd be happy to chat in the Prisma slack.

miguelff pushed a commit that referenced this issue Apr 20, 2023
@tomhoule
Merge pull request #71 from prisma/postgres-null-contstraint-errors-o…
0efd04d 
…n-schema-change

Map null constraint errors from ALTER TABLE on postgres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenberndt carmenberndt

Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines Issue for tech Engines.
Projects
None yet
Milestone
Release 2.6.0
Development

Successfully merging a pull request may close this issue.

Datamodel parser: Native types prisma/prisma-engines
4 participants
@janpio @divideby0 @mavilein @carmenberndt