Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeadlockSpec #83

Closed
mavilein opened this issue Sep 30, 2019 · 2 comments
Closed

Fix DeadlockSpec #83

mavilein opened this issue Sep 30, 2019 · 2 comments
Assignees
Milestone

Comments

@mavilein
Copy link
Contributor

The DeadlockSpec in the connector test kit suddenly started failing. The message i see in the logs in the case of Postgres is:

Error querying the database: db error: FATAL: sorry, too many clients already, application: prisma

It might be a side effect of the latest changes to connection pooling maybe. We should fix this spec.

@mavilein mavilein added this to the Preview 14 milestone Sep 30, 2019
@mavilein
Copy link
Contributor Author

I had one more look at it and noticed the following things:

  • The connections might not be the issue. I noticed that i ended up with tons of zombie prisma processes locally. The connection error seems to be only a sympton.
  • After killing the zombies the CreateMutationSpec still failed for me locally. The error was a connection refused by the query engine process. In the connector test kit we wait 100ms after starting the query engine before sending queries. This suggests that we have a regression in the startup time. Increasing to 1 second made the spec pass.

@pimeys
Copy link
Contributor

pimeys commented Oct 7, 2019

Fixed.

@pimeys pimeys closed this as completed Oct 7, 2019
miguelff pushed a commit that referenced this issue Apr 20, 2023
Test and fix NULL handling in serde module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants