Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration Engine: Implement new diffing approach to enable custom types #85

Closed
mavilein opened this issue Oct 1, 2019 · 2 comments
Closed

Migration Engine: Implement new diffing approach to enable custom types #85

mavilein opened this issue Oct 1, 2019 · 2 comments
Assignees
@tomhoule
Milestone
Preview 16

Comments

@mavilein
Copy link
Contributor

mavilein commented Oct 1, 2019

The Migration Engine needs to be able to diff two data models in order to generate the steps.json that is central to lift. Currently we diff the data structures in the dml module of the datamodel crate. I think we should instead diff the data structures of the ast module instead.
This should make our code easier to maintain and at the same time enables diffing of arbitrary directives. This is required to enbale custom types.
@mavilein mavilein added this to the Preview 14 milestone Oct 1, 2019
@janpio janpio modified the milestones: Preview 14, Preview 15 Oct 11, 2019
@tomhoule
Copy link
Contributor

WIP PR: #97

@janpio janpio modified the milestones: Preview 15, Preview 16 Oct 28, 2019
@matthewmueller matthewmueller mentioned this issue Oct 28, 2019
Closed
@tomhoule
Copy link
Contributor

tomhoule commented Nov 7, 2019

This is complete and merged. Discussion continues in prisma/specs#284

@tomhoule tomhoule closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomhoule tomhoule

Labels
None yet
Projects
None yet
Milestone
Preview 16
Development

No branches or pull requests
3 participants
@janpio @mavilein @tomhoule