Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver-adapters): enable Wasm on request-handlers #4455

Merged
merged 51 commits into from
Nov 21, 2023
Merged

feat(driver-adapters): enable Wasm on request-handlers #4455

merged 51 commits into from
Nov 21, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 15, 2023 •
edited

This PR closes https://github.com/prisma/team-orm/issues/281, and depends on #4445.

jkomyno and others added 30 commits November 10, 2023 13:49
@jkomyno
feat(quaint): allow wasm32-unknown-unknown compilation; currently fai…
61ef25b 
…ls on native
@jkomyno
feat(quaint): split postgres connector into native and wasm submodules
055e696
@jkomyno
feat(quaint): split mysql connector into native and wasm submodules
12c6ebb
@jkomyno
feat(quaint): recover wasm error for mysql
060486d
@jkomyno
feat(quaint): split mssql connector into native and wasm submodules
5de1dc0
@jkomyno
feat(quaint): split sqlite connector into native and wasm submodules
8ecbc5c
@jkomyno
chore(quaint): fix clippy when compiling natively
45df24f
@jkomyno
chore(quaint): fix clippy when compiling to wasm32-unknown-unknown
6a1f733
@jkomyno
chore(quaint): update README
e61bf75
@jkomyno
chore(quaint): rename "*-connector" feature flag to "*-native"
257c4c8
@jkomyno
feat(quaint): enable pure Wasm SqliteError
5ab6d96
@jkomyno
feat(query-connect): allow wasm32-unknown-unknown compilation
ab65c95
@jkomyno
Merge branch 'main' into feat/quaint-on-wasm32-unknown-unknown
485f6dc
@jkomyno
feat(sql-query-connector): allow wasm32-unknown-unknown compilation
cfb5507
@jkomyno
chore(query-engine-wasm): add currently unused local crates to test w…
e7df5a3 
…asm32-unknown-unknown compilation
@jkomyno
chore: update Cargo.lock
8c5d3dc
@jkomyno
chore: remove leftover comments
6648a88
@jkomyno
feat(query-core): allow wasm32-unknown-unknown compilation
754746e
@jkomyno
chore(sql-query-connector): fix clipppy on wasm32
fe2fb8b
@jkomyno
Merge branch 'feat/sql-query-connector-on-wasm32-unknown-unknown' of …
2ffe394 
…github.com:prisma/prisma-engines into feat/sql-query-connector-on-wasm32-unknown-unknown
@jkomyno
Merge branch 'feat/sql-query-connector-on-wasm32-unknown-unknown' int…
e66fb65 
…o feat/query-core-on-wasm32-unknown-unknown
@jkomyno
chore: remove leftover comment
9c41dc1
@jkomyno
feat(driver-adapters): enable Wasm on request-handlers
b69bb84
@miguelff
WIP: refactor mysql module to flatten its structure
c987dce
@jkomyno
feat(quaint): flatten mssql connector module
626bc1e
@jkomyno
feat(quaint): flatten postgres connector module
a9f8ba8
@jkomyno
feat(quaint): flatten sqlite connector module
3c1a100
@jkomyno
chore(quaint): export all public definitions in connector "url" modules
7f4c8f9
@jkomyno
chore(quaint): refactor tests for connectors, addressing feedback
95a4e28
@jkomyno
chore: add comment on MysqlAsyncError
bacb635
@jkomyno jkomyno mentioned this pull request Nov 15, 2023
Closed
@jkomyno jkomyno added this to the 5.7.0 milestone Nov 17, 2023
jkomyno and others added 11 commits November 17, 2023 15:41
@jkomyno
Merge branch 'main' into feat/sql-query-connector-on-wasm32-unknown-u…
33cdf77 
…nknown
@jkomyno
Merge branch 'main' into feat/query-core-on-wasm32-unknown-unknown
2dd3f02
@jkomyno
Merge branch 'feat/sql-query-connector-on-wasm32-unknown-unknown' int…
2afeddc 
…o feat/query-core-on-wasm32-unknown-unknown
@jkomyno
chore: move "task" module into its own file
2339b31
@jkomyno
Merge branch 'main' into feat/query-core-on-wasm32-unknown-unknown
edf0f4e
@jkomyno
Merge branch 'feat/query-core-on-wasm32-unknown-unknown' into feat/re…
5976ab1 
…quest-handlers-on-wasm32-unknown-unknown
@jkomyno
fix(driver-adapters): ci for "request-handlers"
96cd8ca
@jkomyno
fix(driver-adapters): ci for "request-handlers"
3541054
@jkomyno
Merge branch 'main' into feat/sql-query-connector-on-wasm32-unknown-u…
e79cb1f 
…nknown
@jkomyno
Merge branch 'feat/sql-query-connector-on-wasm32-unknown-unknown' int…
e52500f 
…o feat/query-core-on-wasm32-unknown-unknown
@jkomyno
Merge branch 'feat/query-core-on-wasm32-unknown-unknown' into feat/re…
2c70d12 
…quest-handlers-on-wasm32-unknown-unknown
@jkomyno jkomyno marked this pull request as ready for review November 17, 2023 15:33
@jkomyno jkomyno requested a review from a team as a code owner November 17, 2023 15:33
@jkomyno jkomyno requested review from miguelff and Druue and removed request for a team November 17, 2023 15:34
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 17, 2023 •
edited

CodSpeed Performance Report

Merging #4455 will not alter performance

Comparing feat/request-handlers-on-wasm32-unknown-unknown (a82584a) with main (ebb702b)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno removed their assignment Nov 20, 2023
Base automatically changed from feat/query-core-on-wasm32-unknown-unknown to main November 20, 2023 03:20
@SevInf SevInf merged commit ba74bdf into main Nov 21, 2023
52 of 54 checks passed
@SevInf SevInf deleted the feat/request-handlers-on-wasm32-unknown-unknown branch November 21, 2023 11:12
miguelff added a commit that referenced this pull request Nov 22, 2023
@miguelff
Merge remote-tracking branch 'origin/main' into mff/tmp-planetscale-t…
27eff23 
…ests

* origin/main:
  qe: Allow to run query engine test suite against wasm engines (#4467)
  query-engine-wasm: Fix build & ensure it stays fixed (#4488)
  feat(driver-adapters): enable Wasm on `request-handlers` (#4455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weakky Weakky Weakky approved these changes

@miguelff miguelff Awaiting requested review from miguelff miguelff is a code owner automatically assigned from prisma/orm-rust

@Druue Druue Awaiting requested review from Druue Druue is a code owner automatically assigned from prisma/orm-rust

Assignees

@jkomyno jkomyno

Labels
topic: vertical slice 🍰
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jkomyno @Weakky @janpio @SevInf @miguelff