qe: Allow to run query engine test suite against wasm engines #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
requested review from
jkomyno and
Weakky
and removed request for
a team
|
Should wasm test run be added to GH Actions now, even though it fails for pretty much every unskipped test? Or should we wait until vertical slice/functioning WASM engine is in |
SevInf
commented
Nov 20, 2023
query-engine/connector-test-kit-rs/query-tests-setup/src/connector_tag/js/external_process.rs
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #4467 will not alter performanceComparing Summary
|
Added them to the workflow, but commented out until we have an actual engine. |
miguelff
approved these changes
Nov 20, 2023
query-engine/connector-test-kit-rs/query-tests-setup/src/config.rs
Outdated
Show resolved
Hide resolved
SevInf
force-pushed
the
feat/wasm-test-executor
branch
from
731f128
to
a7dea5e
Compare
SevInf
commented
Nov 21, 2023
Intoroduces new environment variable/test config option,
`EXTERNAL_TEST_EXECUTOR_ENGINE` that can be either `NAPI` (default) or
`WASM` that affects which engine external test executor will start with.
Adds a bunch of additional test configs for driver adapters that
duplicate existing ones, but run against WASM engine.
Close prisma/team-orm#551
Specify engine option in `external_test_executor`
SevInf
force-pushed
the
feat/wasm-test-executor
branch
from
407819b
to
4fc6b33
Compare
|
Thank you for addressing the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intoroduces new environment variable/test config option,
EXTERNAL_TEST_EXECUTOR_ENGINEthat can be eitherNAPI(default) orWASMthat affects which engine external test executor will start with.Adds a bunch of additional test configs for driver adapters that
duplicate existing ones, but run against WASM engine.
Close prisma/team-orm#551