feat(driver-adapters): enable Wasm on driver-adapters, with further deduplications required later
#4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asm32-unknown-unknown compilation
…github.com:prisma/prisma-engines into feat/sql-query-connector-on-wasm32-unknown-unknown
…o feat/query-core-on-wasm32-unknown-unknown
jkomyno
requested review from
miguelff and
Druue
and removed request for
a team
Weakky
reviewed
Nov 20, 2023
Comment on lines
27
to
41
|
|
||
| [target.'cfg(not(target_arch = "wasm32"))'.dependencies] | ||
| napi.workspace = true | ||
| napi-derive.workspace = true | ||
| quaint.workspace = true | ||
|
|
||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| quaint = { path = "../../quaint" } | ||
| js-sys.workspace = true | ||
| serde-wasm-bindgen.workspace = true | ||
| wasm-bindgen.workspace = true | ||
| wasm-bindgen-futures.workspace = true | ||
| tsify.workspace = true | ||
| ducktor = "0.1.0" | ||
| pin-project = "1" |
There was a problem hiding this comment.
I believe you should be able to use quaint's workspace version in both cases here. See doc here
There was a problem hiding this comment.
Thanks, I didn't know this about resolver = "2".
Weakky
reviewed
Nov 20, 2023
| wasm-bindgen.workspace = true | ||
| wasm-bindgen-futures.workspace = true | ||
| tsify.workspace = true | ||
| ducktor = "0.1.0" |
There was a problem hiding this comment.
This dependency, ducktor, looks scary tbh. Looks unknown, a few months old with barely any tests. How much work does it remove from our plate?
There was a problem hiding this comment.
ducktor was one of the shortcuts taken (I already had some code using it laying around).
Removed in d6d09d6.
There was a problem hiding this comment.
Looks like this change broke something:
Error: `unwrap_throw` failed
at __wbindgen_throw (file:///Users/jkomyno/work/prisma/prisma-engines/query-engine/query-engine-wasm/pkg/query_engine_bg.js:977:11)
at wasm://wasm/01063c0e:wasm-function[5374]:0x352371
at wasm://wasm/01063c0e:wasm-function[3153]:0x32513b
at wasm://wasm/01063c0e:wasm-function[93]:0x3902b
I'll take another look tomorrow.
Weakky
reviewed
Nov 20, 2023
| @@ -125,10 +126,12 @@ impl QueryEngine { | |||
|
|
|||
| let mut schema = psl::validate(datamodel.into()); | |||
| let config = &mut schema.configuration; | |||
| let preview_features = config.preview_features(); | |||
Weakky
suggested changes
Nov 21, 2023
Base automatically changed from
feat/request-handlers-on-wasm32-unknown-unknown
to
main
November 21, 2023 11:12
|
This is currently broken, see #4456 (comment). |
jkomyno
changed the title
driver-adaptersdriver-adapters, with further deduplications required later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to https://github.com/prisma/team-orm/issues/548, and depends on #4455.
Idea: add Wasm support to
driver-adapters, which currently relies onnapi.rsonly, by splitting the wasm-specific logic into thewasmmodule, and thenapi.rs-specific logic into thenapimodule.These modules are mutually exclusive and provide almost the same public API.
The
wasmmodule is compiled when the target architecture iswasm32-*, andnapiis used otherwise.See Slack thread for context about it.
For what is worth, I think this PR is good enough for getting the vertical slice asap, but not for integrating into
main, as I pointed our in a few comments.