Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-engine-wasm): vertical slice #4466

Merged
merged 183 commits into from
Dec 8, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 20, 2023

This PR is based on #4456, and contributes to https://github.com/prisma/team-orm/issues/549 (but it's not feature complete yet, so it doesn't close it).

This is the source code of @prisma/query-engine-wasm version 0.0.6 0.0.18.

Closes #4121

jkomyno and others added 30 commits November 10, 2023 13:49
…github.com:prisma/prisma-engines into feat/sql-query-connector-on-wasm32-unknown-unknown
jkomyno and others added 2 commits December 5, 2023 18:32
* qe-wasm: Partially fix the test suite

1. Bash script for build did not abort on error, hence sed error on
   linux went unnoticed.
2. We don't actually need sed trickery sincce `wasm-pack` has a flag for
   changing binary name.
3. `tracing` feature does not actually work on WASM even partially: it panics on
   `Instant` invokation as soon as first span is created. Since we are
   running tests with all preview features enabled, that means that
   practically any test panics now. Disabled it again.

A lot of tests are still failing on ThreadRng invocation and stacktrace
is not really helpful, but I still think it's better if we get it
working.

* Update query-engine/query-engine-wasm/build.sh
@SevInf SevInf force-pushed the feat/query-engine-wasm32-unknown-unknown branch 2 times, most recently from d7ad5d5 to c7c8586 Compare December 6, 2023 10:25
@SevInf SevInf marked this pull request as ready for review December 7, 2023 13:32
@SevInf SevInf requested a review from a team as a code owner December 7, 2023 13:32
@SevInf SevInf requested review from miguelff and Weakky and removed request for a team December 7, 2023 13:32
* Add a way to skip WASM tests

* Temproary skip failing wasm tests on pg and neon

* Skip timstamp test

* Fix incorrect skips

* Parse libsql.js.wasm version

* Skip libsql wasm tests

* Fix vitess version parsing

* Skip wasm planetscale tests that are also skipped for napi

* Rename jobs

* Skip planetscale wasm tests

* Fix some incorrect skips

* And more fixes

* Be careful when copy-pasting, please

* One more fix

* Fix null lists

* Again: be careful when copy-pasting

* Skip timestamp test on libsql and planetscale

* Update .github/workflows/test-query-engine-driver-adapters.yml

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>

---------

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Copy link
Contributor

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@SevInf SevInf merged commit dcb8cb9 into main Dec 8, 2023
71 checks passed
@SevInf SevInf deleted the feat/query-engine-wasm32-unknown-unknown branch December 8, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants