Skip to content

Commit

Permalink
ci(GitHub): improve daily tests/CI workflows (#19132)
Browse files Browse the repository at this point in the history
* ci: Improve daily builds/CI workflows

1. Splits most of the workflow in a separate reusable template
file. This allows us to safely use defaults of workflow inputs
regardless of the reasons workflow got triggered and don't think about
fallback every time we need to use the input.
2. "Detect jobs to run" step, as well as the attempt to find "ci test
all" comment now will be done only in CI workflow. Scheduled jobs
will autoamtically build everything.

* Review
  • Loading branch information
SevInf committed May 8, 2023
1 parent fffbd79 commit 8df9331
Show file tree
Hide file tree
Showing 5 changed files with 1,385 additions and 1,359 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/daily-buildpulse.yml
Expand Up @@ -8,8 +8,9 @@ on:

jobs:
run_tests:
uses: ./.github/workflows/test.yml
uses: ./.github/workflows/test-template.yml
with:
reason: buildpulse
jobTimeout: 70
ubuntuRunner: ubuntu-latest
testAll: true
3 changes: 2 additions & 1 deletion .github/workflows/daily-test.yml
Expand Up @@ -8,11 +8,12 @@ on:

jobs:
run_tests:
uses: ./.github/workflows/test.yml
uses: ./.github/workflows/test-template.yml
with:
reason: daily-test
jobTimeout: 70
ubuntuRunner: ubuntu-latest
testAll: true
failure:
needs:
- run_tests
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/scripts/build-client-matrix.js
Expand Up @@ -2,17 +2,15 @@
'use strict'
const fs = require('fs')

const [reason, buildComment] = process.argv.slice(2)
console.log({ reason, buildComment })

const hasBuildAllComment = buildComment?.length > 0
const testAll = process.argv[2] === 'true'
console.log({ testAll })

const excludeClient = []
const excludeDataProxy = []

const queryEngine = ['library']

if (hasBuildAllComment || reason === 'daily-test') {
if (testAll) {
queryEngine.push('binary')
} else {
excludeClient.push({ node: 18, engineProtocol: 'json' })
Expand Down

0 comments on commit 8df9331

Please sign in to comment.