-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(GitHub): improve daily tests/CI workflows #19132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
force-pushed
the
feat/daily-build-followup
branch
from
May 8, 2023 10:23
2284aad
to
d2a3249
Compare
SevInf
changed the title
WIP: follow up to daily builds work
ci: Improve daily builds/CI workflows
May 8, 2023
1. Splits most of the workflow in a separate reusable template file. This allows us to safely use defaults of workflow inputs regardless of the reasons workflow got triggered and don't think about fallback every time we need to use the input. 2. "Detect jobs to run" step, as well as the attempt to find "ci test all" comment now will be done only in CI workflow. Scheduled jobs will autoamtically build everything.
SevInf
force-pushed
the
feat/daily-build-followup
branch
from
May 8, 2023 10:31
d2a3249
to
d3f70e6
Compare
Jolg42
reviewed
May 8, 2023
Jolg42
reviewed
May 8, 2023
aqrln
approved these changes
May 8, 2023
Jolg42
reviewed
May 8, 2023
Jolg42
reviewed
May 8, 2023
CodSpeed Performance ReportMerging #19132 Summary
|
Jolg42
changed the title
ci: Improve daily builds/CI workflows
ci(GitHub): improve daily tests/CI workflows
May 8, 2023
Jolg42
approved these changes
May 8, 2023
Looks good so far! ✨ https://github.com/prisma/prisma/actions/runs/4916696460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file. This allows us to safely use defaults of workflow inputs
regardless of the reasons workflow got triggered and don't think about
fallback every time we need to use the input.
all" comment now will be done only in CI workflow. Scheduled jobs
will automatically test everything.