Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(GitHub): improve daily tests/CI workflows #19132

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented May 8, 2023

  1. Splits most of the workflow in a separate reusable template
    file. This allows us to safely use defaults of workflow inputs
    regardless of the reasons workflow got triggered and don't think about
    fallback every time we need to use the input.
  2. "Detect jobs to run" step, as well as the attempt to find "ci test
    all" comment now will be done only in CI workflow. Scheduled jobs
    will automatically test everything.

@SevInf SevInf force-pushed the feat/daily-build-followup branch from 2284aad to d2a3249 Compare May 8, 2023 10:23
@SevInf SevInf changed the title WIP: follow up to daily builds work ci: Improve daily builds/CI workflows May 8, 2023
@SevInf SevInf added this to the 4.14.0 milestone May 8, 2023
@SevInf SevInf marked this pull request as ready for review May 8, 2023 10:28
@SevInf SevInf requested review from Jolg42 and jkomyno as code owners May 8, 2023 10:28
@SevInf SevInf requested review from a team and millsp and removed request for a team May 8, 2023 10:28
1. Splits most of the workflow in a separate reusable template
file. This allows us to safely use defaults of workflow inputs
regardless of the reasons workflow got triggered and don't think about
fallback every time we need to use the input.
2. "Detect jobs to run" step, as well as the attempt to find "ci test
all" comment now will be done only in CI workflow. Scheduled jobs
will autoamtically build everything.
@SevInf SevInf force-pushed the feat/daily-build-followup branch from d2a3249 to d3f70e6 Compare May 8, 2023 10:31
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2023

CodSpeed Performance Report

Merging #19132 feat/daily-build-followup (f03249a) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 3 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@Jolg42 Jolg42 changed the title ci: Improve daily builds/CI workflows ci(GitHub): improve daily tests/CI workflows May 8, 2023
@SevInf SevInf requested a review from Jolg42 May 8, 2023 14:13
@SevInf SevInf merged commit 8df9331 into main May 8, 2023
38 checks passed
@SevInf SevInf deleted the feat/daily-build-followup branch May 8, 2023 15:13
@Jolg42
Copy link
Member

Jolg42 commented May 8, 2023

Looks good so far! ✨ https://github.com/prisma/prisma/actions/runs/4916696460
Screenshot 2023-05-08 at 17 26 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants