Skip to content

Commit

Permalink
chore: update some TODO comments after workshop (#18590)
Browse files Browse the repository at this point in the history
* Remove a comment that we decided was wrong
* Change another comment to ask for a different thing
  • Loading branch information
aqrln committed Apr 4, 2023
1 parent 0326571 commit ed52837
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
Expand Up @@ -9,7 +9,6 @@ const semverRegex = /^[1-9][0-9]*\.[0-9]+\.[0-9]+$/
const debug = Debug('prisma:client:dataproxyEngine')

async function _getClientVersion(config: EngineConfig) {
// TODO: now we can probably just use the client version instead
const engineVersion = devDependencies['@prisma/engines-version']
const clientVersion = config.clientVersion ?? 'unknown'

Expand Down
2 changes: 1 addition & 1 deletion packages/engine-core/src/library/DefaultLibraryLoader.ts
Expand Up @@ -66,7 +66,7 @@ export class DefaultLibraryLoader implements LibraryLoader {
const incorrectPinnedPlatformErrorStr = this.platform
? `\nYou incorrectly pinned it to ${chalk.redBright.bold(`${this.platform}`)}\n`
: ''
// TODO Improve search engine logic possibly using findSync
// TODO Stop searching in many locations, have more deterministic logic.
let errorText = `Query engine library for current platform "${chalk.bold(
this.platform,
)}" could not be found.${incorrectPinnedPlatformErrorStr}
Expand Down

0 comments on commit ed52837

Please sign in to comment.