Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update some TODO comments after workshop #18590

Merged
merged 1 commit into from
Apr 4, 2023
Merged

chore: update some TODO comments after workshop #18590

merged 1 commit into from
Apr 4, 2023

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Mar 31, 2023

  • Remove a comment that we decided was wrong
  • Change another comment to ask for a different thing

* Remove a comment that we decided was wrong
* Change another comment to ask for a different thing
@aqrln aqrln requested review from a team and millsp and removed request for a team March 31, 2023 17:30
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2023

CodSpeed Performance Report

Merging #18590 chore/comments (10770e1) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 3 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@aqrln aqrln added this to the 4.13.0 milestone Apr 1, 2023
@aqrln aqrln merged commit ed52837 into main Apr 4, 2023
53 checks passed
@aqrln aqrln deleted the chore/comments branch April 4, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants