@prisma/client/edge + Cloudflare Worker / wrangler = Could not resolve "os"

[zzzej]

Bug description

It was running just fine. I updated prisma and reinstalled dependencies then did npx prisma generate --data-proxy. Generates the client, but right after starting the server with wrangler dev src/index.ts I get

How to reproduce

1. Run a basic Cloudflare worker wrangler.toml

name = "api"
compatibility_date = "2023-04-19"

2. Generate prisma with data proxy npx prisma generate --data-proxy
3. Setup/connect prisma.
4. Start wrangler wrangler dev src/index.ts
5. Get error

Expected behavior

Server starts and Prisma edge client works.

Prisma information

import { PrismaClient } from "@prisma/client/edge";

export default function prisma(url: string) {
  const client = new PrismaClient({
    datasources: {
      db: {
        url,
      },
    },
  });

  return client;
}

export type ExtendedPrismaClient = ReturnType<typeof prisma>;

generator client {
  provider = "prisma-client-js"
  previewFeatures = ["clientExtensions", "jsonProtocol"]
  // ALSO TESTED WITH NO PREVIEW FEATURES
}

datasource db {
  provider = "mysql"
  url = env("DATABASE_URL")
  relationMode = "prisma"
}

Environment & setup

• OS: macOS Apple M2 Pro
• Database: PlanetScale MySQL
• Node: 18.16

Prisma Version

4.14

[zzzej]

Update: It works when I manually set Rp={} instead of Rp=require("os") in edge.js

Before:

After:

[Jolg42]

@osejrafael Thanks for this issue! Do you know if this error also happens with a previous version of Prisma, like 4.13.0 or earlier? Maybe this is a recent change 🤔

[zzzej]

@Jolg42 Yes, I tried rolling back to 4.13.0 and I got the same error. Which is weird since that was the only change I made. "Update from 4.13.0 -> 4.14.0 and generate client with --data-proxy"

[alexvuka1]

I have been using @prisma/client/edge on Vercel Edge (using @astrojs/vercel/edge) and it has been working fine on version 4.13.0, but when I tried updating to 4.14.0 I got the same error as @osejrafael

[oanogin]

I have the same issue with 4.14.0 :/
Workaround 1: replace Rp=require("os") with Rp={} in ../node_modules/@prisma/client/runtime/edge.js (as @osejrafael said couple hours ago)
Workaround 2: add node_compat = true line to wrangler.toml file

[Jolg42]

Thanks all! I'll try a reproduction tomorrow, as this looks like an unexpected regression 👀

In the meantime, I can recommend staying on 4.13.0 and stay tuned.

[alexvuka1]

The file ExitHooks.ts is new in 4.14.0 and it imports os:

prisma/packages/client/src/runtime/core/engines/library/ExitHooks.ts

Line 2 in 18313b3

import os from 'os'

Not sure if it is the root of the problem, but might be useful.

[Jolg42]

@alexvuka1 Thanks! I also found that this was the most recent addition, potentially that's the problem here.

[millsp]

I can confirm I have seen this in the bundled files. We should add a test that no require/import exists in our edge runtime. Currently os imports are not actually required and we could juts blank it out.

[Jolg42]

I got a reproduction in our ecosystem-tests prisma/ecosystem-tests#3508 after updating wrangler
I'll merge my PR for updating our cloudflare worker test, and it will most probably be fixed by #19186 once merged
We'll come back with a confirmation once all testing went through.

[Jolg42]

Note: after testing some versions. I can confirm it's a regression that happened in 4.14.0 and it started with 4.14.0-dev.17 which was published after #18900

[Jolg42]

Note: confirmed fixed on main branch.
Our internal dev version 4.15.0-dev.13 has the fix and passes the ecosystem-tests

[Jolg42]

Note: we are planning an official patch release later today. Stay tuned 😉

[millsp]

The fix is now available https://github.com/prisma/prisma/releases/tag/4.14.1. Thanks for the report.