Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client-edge): build fillers - remove os #19195

Merged
merged 1 commit into from
May 11, 2023
Merged

fix(client-edge): build fillers - remove os #19195

merged 1 commit into from
May 11, 2023

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented May 11, 2023 •
edited

Closes #19174

@Jolg42 Jolg42 added this to the 4.15.0 milestone May 11, 2023
@Jolg42
Copy link
Member Author

Jolg42 commented May 11, 2023

Actually in https://github.com/prisma/prisma/pull/18900/files#diff-b6998702709f00186744b9796796d3b05b235799ef5483e6872916acdcac432c

The code removed that triggered the "os" issue is

      // removes un-needed code out of `chalk`
      'supports-color': { contents: '' },

@Jolg42
Copy link
Member Author

Jolg42 commented May 11, 2023

I can confirm by a manual test on Cloudflare workers that 4.15.0-integration-os-edge-client.1 works now.

@Jolg42 Jolg42 changed the title fix(client): fillers, remove os for edge client fix(client-edge): build fillers - remove os May 11, 2023
@Jolg42 Jolg42 marked this pull request as ready for review May 11, 2023 13:01
@Jolg42 Jolg42 requested a review from jkomyno as a code owner May 11, 2023 13:01
@Jolg42 Jolg42 requested review from a team, aqrln, millsp and SevInf and removed request for a team May 11, 2023 13:01
@Jolg42 Jolg42 merged commit a68e72b into main May 11, 2023
37 of 39 checks passed
@Jolg42 Jolg42 deleted the integration/os-edge-client branch May 11, 2023 14:26
millsp pushed a commit that referenced this pull request May 16, 2023
@Jolg42 @millsp
fix(client-edge): build fillers - remove os (#19195)
2f1277e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

@millsp millsp millsp approved these changes

@aqrln aqrln Awaiting requested review from aqrln

@SevInf SevInf Awaiting requested review from SevInf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.15.0
Development

Successfully merging this pull request may close these issues.

@prisma/client/edge + Cloudflare Worker / wrangler = Could not resolve "os"
3 participants
@Jolg42 @jkomyno @millsp