Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON autocompletion #3441

Closed
timsuchanek opened this issue Aug 26, 2020 · 5 comments · Fixed by #3446
Closed

Fix JSON autocompletion #3441

timsuchanek opened this issue Aug 26, 2020 · 5 comments · Fixed by #3446
Assignees
@timsuchanek @dpetrick
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. tech/typescript Issue for tech TypeScript. topic: union types
Milestone
Release 2.8.0

Comments

@timsuchanek
Copy link
Contributor

As mentioned here:
#3364 (comment)
@timsuchanek timsuchanek self-assigned this Aug 26, 2020
@timsuchanek timsuchanek added this to the Backlog 2.6.0 milestone Aug 26, 2020
@timsuchanek timsuchanek added bug/2-confirmed Bug has been reproduced and confirmed. tech/typescript Issue for tech TypeScript. labels Aug 26, 2020
@timsuchanek timsuchanek mentioned this issue Aug 26, 2020
Closed
timsuchanek added a commit that referenced this issue Aug 27, 2020
@timsuchanek
fix: autocompletion
efb6f1c 
Closes #3441
@timsuchanek timsuchanek mentioned this issue Aug 27, 2020
Merged
@janpio janpio modified the milestones: Backlog 2.6.0, Release 2.6.0 Aug 28, 2020
@MichalLytek
Copy link

@janpio I can't see the fix in 2.6.0 😕

image

@MichalLytek
Copy link

I believe it has to be fixed on DMMF level as otherwise typegraphql-prisma would need to make a special filtering case to not expose nested json inputs in mutations.

@Jolg42
Copy link
Member

Jolg42 commented Sep 1, 2020

Thanks for the feedback, I'll reopen the issue and @timsuchanek will have a look next week then.

@Jolg42 Jolg42 reopened this Sep 1, 2020
@janpio janpio modified the milestones: Release 2.6.0, Backlog 2.7.0 Sep 1, 2020
@janpio janpio added kind/bug A reported bug. and removed process/next-milestone labels Sep 1, 2020
@timsuchanek
Copy link
Contributor Author

This needs a change in the DMMF, which is being done by @dpetrick anyway in a bigger refactor right now.

@janpio janpio modified the milestones: Backlog 2.7.0, Backlog 2.8.0 Sep 16, 2020
@timsuchanek
Copy link
Contributor Author

Fixed in 2.8.0

@Jolg42 Jolg42 modified the milestones: Backlog 2.8.0, Release 2.8.0 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timsuchanek timsuchanek

@dpetrick dpetrick

Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. tech/typescript Issue for tech TypeScript. topic: union types
Projects
None yet
Milestone
Release 2.8.0
Development

Successfully merging a pull request may close this issue.

fix: autocompletion prisma/prisma
5 participants
@janpio @timsuchanek @Jolg42 @dpetrick @MichalLytek