Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency undici to v5.5.1 [security] #13862

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 17, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
undici (source) 5.4.0 -> 5.5.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2022-32210

Description

Undici.ProxyAgent never verifies the remote server's certificate, and always exposes all request & response data to the proxy. This unexpectedly means that proxies can MitM all HTTPS traffic, and if the proxy's URL is HTTP then it also means that nominally HTTPS requests are actually sent via plain-text HTTP between Undici and the proxy server.

Impact

This affects all use of HTTPS via HTTP proxy using Undici.ProxyAgent with Undici or Node's global fetch. In this case, it removes all HTTPS security from all requests sent using Undici's ProxyAgent, allowing trivial MitM attacks by anybody on the network path between the client and the target server (local network users, your ISP, the proxy, the target server's ISP, etc).
This less seriously affects HTTPS via HTTPS proxies. When you send HTTPS via a proxy to a remote server, the proxy can freely view or modify all HTTPS traffic unexpectedly (but only the proxy).

Example:

setGlobalDispatcher(new ProxyAgent('http://localhost:8000/')) // HTTP Proxy
// or
undici.request('https://example.com/', { dispatcher: new ProxyAgent('http://localhost:8000') }) // HTTP Proxy
// or
fetch('https://example.com/', { dispatcher: new ProxyAgent('http://localhost:8000') }) // HTTP Proxy

Patches

This issue was patched in Undici v5.5.1.

Workarounds

At the time of writing, the only workaround is to not use ProxyAgent as a dispatcher for TLS Connections.

For more information

If you have any questions or comments about this advisory:


Release Notes

nodejs/undici

v5.5.1

Compare Source

⚠️ v5.5.1 - Security release

This releases fixes CVE CVE-2022-32210. See GHSA-pgw7-wx7w-2w33 for more details:

Undici.ProxyAgent never verifies the remote server's certificate, and always exposes all request & response data to the proxy. This unexpectedly means that proxies can MitM all HTTPS traffic, and if the proxy's URL is HTTP then it also means that nominally HTTPS requests are actually sent via plain-text HTTP between Undici and the proxy server.

Full Changelog: nodejs/undici@v5.5.0...v5.5.1

v5.5.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v5.4.0...v5.5.0


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team June 17, 2022 04:17
@renovate renovate bot requested review from Jolg42 and jkomyno as code owners June 17, 2022 04:17
@renovate renovate bot requested review from millsp, aqrln, danstarns and SevInf and removed request for a team June 17, 2022 04:17
@renovate renovate bot force-pushed the renovate/npm-undici-vulnerability branch 2 times, most recently from a94203f to 7274180 Compare June 19, 2022 09:22
@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 21, 2022
@renovate renovate bot force-pushed the renovate/npm-undici-vulnerability branch from 7274180 to a401177 Compare June 22, 2022 06:36
@millsp millsp merged commit b1be412 into main Jun 22, 2022
@millsp millsp deleted the renovate/npm-undici-vulnerability branch June 22, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants