Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ found: true } possible unexpected behavior. #1

Closed
Nicktho opened this issue Mar 15, 2016 · 2 comments
Closed

{ found: true } possible unexpected behavior. #1

Nicktho opened this issue Mar 15, 2016 · 2 comments

Comments

@Nicktho
Copy link
Contributor

Nicktho commented Mar 15, 2016

There are currently no tests to check whether found: true is included in the resolved object from a call to get in the controllers.

Adding such a test found it breaks when params.count !== true, even if responses are found, I assume its this line here: https://github.com/Prismatik/redbeard/blob/master/controller/controller.mustache#L93

The tag probably should be result

@nwinch
Copy link
Contributor

nwinch commented May 9, 2016

Adding such a test found it breaks

@Nicktho Just checking - did you add a test for this at some point?

@davidbanham
Copy link
Contributor

found should never actually be serialised over the API. It's just an internal flag used to denote "Hey! Send a 404!". It's being removed, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants