-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prismicH.asImageSrc
using width
instead of w
doesn't do anything
#63
Comments
Hi there, thank you so much for the report! Following our Maintenance Process, we will review your bug report and get back to you next Wednesday. To ensure a smooth review of your issue and avoid unnecessary delays, please make sure your issue includes the following:
If you have identified the cause of the bug described in your report and know how to fix it, you're more than welcome to open a pull request addressing it. Check out our quick start guide for a simple contribution process. If you think your issue is a question (not a bug) and would like quicker support, please close this issue and forward it to an appropriate section on our community forum: https://community.prismic.io - The Prismic Open-Source Team |
Hey there, thank you so much for contributing. I'm sorry we failed to get back to you in a timely manner. I tried reproducing without success, those tests pass as expected (committed version: 5ee387a /CI results: https://github.com/prismicio/prismic-helpers/actions/runs/5465804619/jobs/9949788226): expect(
asImageSrc(field, {
w: 250,
h: 250,
q: 75,
fm: "webp",
fit: "crop",
}),
).toBe(`${field.url}&w=250&h=250&q=75&fm=webp&fit=crop`);
expect(
asImageSrc(field, {
width: 250,
height: 250,
q: 75,
fm: "webp",
fit: "crop",
}),
).toBe(`${field.url}&width=250&height=250&q=75&fm=webp&fit=crop`); Equivalent images appear to be rendered as expected:
I'm confused if I got your issue correctly, maybe this was a regression back then on Imgix's end? Well let me know, I'm closing it for now but happy to reopen~ |
Versions
Steps to reproduce
What is expected?
Using the param
width
andheight
optimize the imageWhat is actually happening?
The param
width
andheight
have no effectThe text was updated successfully, but these errors were encountered: