Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguishing Schnorr signature #4

Closed
jae-cuz opened this issue Sep 6, 2023 · 2 comments
Closed

Distinguishing Schnorr signature #4

jae-cuz opened this issue Sep 6, 2023 · 2 comments

Comments

@jae-cuz
Copy link
Contributor

jae-cuz commented Sep 6, 2023

Summary

Schnorr signature based on traditional DLP and ECDLP are not distinguished.

Location

  • Module Name: Module 3
  • Section/Step: Schnorr Signatures

Proposed Correction

Schnorr signature was originally published based on traditional Discrete Logarithm Problem. EC(Elliptic Curve)-Schnorr was introduced later.
These two seems not to be distinguished strictly in several materials. Among 5 links of Schnorr signature in Module 3, two links describe DLP version while other links describe EC version.

Erasing DLP links would be one solution.
However I suggest the way to move DLP-Schnorr signature to Module 2, as we introduced only one digital signature scheme(DSA) in Module 2. (Historically, DSA is proposed with intent to avoid patent issue of original Schnorr signature.)

Please let me know if you have other opinion, and thanks for your hard work writing these helpful materials! 😄

Screenshots (if applicable)

image

Additional Context

schnorr vs ec-schnorr

@adrianmcli
Copy link
Collaborator

@jae-cuz Thank you for this issue! This is a great point and I think your recommendation makes a lot of sense. Looking forward to seeing a PR with your suggested changes.

@adrianmcli
Copy link
Collaborator

Fixed by #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants